Sign upLogin

VoxaAI/voxa-cli

View on GitHub
Star
src/DialogflowSchema.ts

Summary

Maintainability
D
2 days
Test Coverage

File DialogflowSchema.ts has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2018 Rain Agency <contact@rain.agency>
 * Author: Rain Agency <contact@rain.agency>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy of
Severity: Minor
Found in src/DialogflowSchema.ts - About 3 hrs to fix

    Function buildIntent has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public buildIntent(locale: string, environment: string) {
    const intentsByPlatformAndEnvironments = this.intentsByPlatformAndEnvironments(
      locale,
      environment
    );
    Severity: Major
    Found in src/DialogflowSchema.ts - About 2 hrs to fix

      Function buildUtterances has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public buildUtterances(locale: string, environment: string) {
    const intentsByPlatformAndEnvironments = this.intentsByPlatformAndEnvironments(
      locale,
      environment
    );
      Severity: Major
      Found in src/DialogflowSchema.ts - About 2 hrs to fix

        Function builtIntents has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            this.builtIntents = intentsByPlatformAndEnvironments.map((rawIntent: IIntent) => {
      let { name, events } = rawIntent;
      const { parameterName, parameterValue } = rawIntent;
      const { webhookForSlotFilling, slotsDefinition, responses, webhookUsed } = rawIntent;
      name = name.replace("AMAZON.", "");
        Severity: Major
        Found in src/DialogflowSchema.ts - About 2 hrs to fix

          Function buildAgent has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public buildAgent(locale: string, environment: string) {
    const intents = this.builtIntents;
    const invocation = _.find(this.invocations, { locale, environment });
    const invocationName = _.get(invocation, "name", "Skill with no name");
    const intentsByPlatformAndEnvironments = this.intentsByPlatformAndEnvironments(
          Severity: Minor
          Found in src/DialogflowSchema.ts - About 1 hr to fix

            Function buildIntent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              public buildIntent(locale: string, environment: string) {
    const intentsByPlatformAndEnvironments = this.intentsByPlatformAndEnvironments(
      locale,
      environment
    );
            Severity: Minor
            Found in src/DialogflowSchema.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function resultSamples has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  const resultSamples = samples.map(sample => {
        const data = _.chain(sample)
          .replace(/{([^}]+)}/g, (match, inner) => {
            return `|{${inner}}|`;
          })
            Severity: Minor
            Found in src/DialogflowSchema.ts - About 1 hr to fix

              Function buildEntities has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public buildEntities(locale: string, environment: string) {
    const localeEntity = this.getLocale(locale);

    this.getSlotsByIntentsDefinition(locale, environment)
      .filter(slot => !_.includes(slot.name, "@sys."))
              Severity: Minor
              Found in src/DialogflowSchema.ts - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        const file: IFileContent = {
          path: this.buildFilePath(environment, "intents", `${name}_usersays_${locale}.json`),
          content: resultSamples
        };
                Severity: Minor
                Found in src/DialogflowSchema.ts and 1 other location - About 35 mins to fix
                src/DialogflowSchema.ts on lines 362..369

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        const fileValue: IFileContent = {
          path: this.buildFilePath(
            environment,
            "entities",
            `${slotName}_entries_${localeEntity}.json`
                Severity: Minor
                Found in src/DialogflowSchema.ts and 1 other location - About 35 mins to fix
                src/DialogflowSchema.ts on lines 252..255

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status