Sign upLogin

VsevolodTrofimov/Ripple.js

View on GitHub
Star

Showing 39 of 39 total issues

Function show has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  show(target, event) {
    // setup
    let self = this
    let rect = this.getRect(target)
Severity: Minor
Found in src/ripple.js - About 1 hr to fix

    Function getFirstObjectExp has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function getFirstObjectExp(str) {
  var opened = 0,
      started = false,
      comment = false,
      obj = "";
    Severity: Minor
    Found in docs/demo.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function hadlerFactory has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function hadlerFactory(el, rippleFactory) {
  // scoping
  return function () {
    let ripples = []
    let startTimeDate = undefined
    Severity: Minor
    Found in src/binders.js - About 1 hr to fix

      Function watch has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function watch(selector = "*", rippleFactory, scope = document) {
  let handle = hadlerFactory(scope, rippleFactory)

  let startAdapter = function(event) {
    let el = event.target
      Severity: Minor
      Found in src/binders.js - About 1 hr to fix

        Function watch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function watch(selector = "*", rippleFactory, scope = document) {
  let handle = hadlerFactory(scope, rippleFactory)

  let startAdapter = function(event) {
    let el = event.target
        Severity: Minor
        Found in src/binders.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if(this.props.borderRadius === 'auto') {
      borderRadius = getStyle(target, 'border-radius')
    } else {
      borderRadius = this.props.borderRadius
    }
        Severity: Minor
        Found in src/ripple.js and 1 other location - About 45 mins to fix
        src/ripple.js on lines 57..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if(this.props.borderWidth === 'auto') {
      borderWidth = getStyle(target, 'border-width')
    } else {
      borderWidth = this.props.borderWidth
    }
        Severity: Minor
        Found in src/ripple.js and 1 other location - About 45 mins to fix
        src/ripple.js on lines 51..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            let documentTop = parseInt(getStyle(document.body.parentElement, 'margin-top'), 10) + parseInt(getStyle(document.body.parentElement, 'padding-top'), 10)
        Severity: Minor
        Found in src/ripple.js and 1 other location - About 35 mins to fix
        src/ripple.js on lines 135..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            let documentLeft = parseInt(getStyle(document.body.parentElement, 'margin-left'), 10) + parseInt(getStyle(document.body.parentElement, 'padding-left'), 10)
        Severity: Minor
        Found in src/ripple.js and 1 other location - About 35 mins to fix
        src/ripple.js on lines 133..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          show(target, event) {
    // setup
    let self = this
    let rect = this.getRect(target)
        Severity: Minor
        Found in src/ripple.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Adjoining classes: .ripple__effect.ripple__effect--hidden
        Open

        .ripple__effect.ripple__effect--hidden {
        Severity: Minor
        Found in src/ripple.css by csslint

        Heading (h1) has already been defined.
        Open

        h1 {
        Severity: Minor
        Found in docs/demo.css by csslint

        The universal selector (*) is known to be slow.
        Open

        .demo > * {
        Severity: Minor
        Found in docs/demo.css by csslint

        Outlines shouldn't be hidden unless other visual changes are made.
        Open

        button:focus, button:hover,*[contenteditable]:focus {
        Severity: Minor
        Found in docs/demo.css by csslint

        Rule doesn't have all its properties in alphabetical order.
        Open

        .btn--transparent {
        Severity: Minor
        Found in docs/demo.css by csslint

        The box-sizing property isn't supported in IE6 and IE7.
        Open

          box-sizing: border-box;
        Severity: Minor
        Found in src/ripple.css by csslint

        Use of !important
        Open

          opacity: 0 !important;
        Severity: Minor
        Found in src/ripple.css by csslint

        Rule doesn't have all its properties in alphabetical order.
        Open

        h1 {
        Severity: Minor
        Found in docs/demo.css by csslint

        Rule doesn't have all its properties in alphabetical order.
        Open

        .ripple {
        Severity: Minor
        Found in src/ripple.css by csslint

        Rule doesn't have all its properties in alphabetical order.
        Open

        .ripple__effect.ripple__effect--hide {
        Severity: Minor
        Found in src/ripple.css by csslint
        Severity
        Category
        Status
        Source
        Language