Sign upLogin

WRidder/react-spa

View on GitHub
Star

Showing 52 of 52 total issues

Avoid deeply nested control flow statements.
Open

            for (var search = 0; search < objects.length; search ++){
              if (objects[search] === objects[index][key1]){
                processed = true;
                break;
              }
Severity: Major
Found in client/src/helper/sizeof.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                if (objects[index].hasOwnProperty(key)) {
              size += 2 * key.length;
            }
    Severity: Major
    Found in client/src/helper/sizeof.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  for (var j = 0; j < subRoutes.length; j++) {
              var subRoute = subRoutes[j];
              if (subRoute.length > 1 && subRoute.charAt(0) !== ":" && "/" + subRoute !== route.path) {
                var subRouteDefinition = availableRoutes.get("children").find(subRouteMatcher.bind(null, subRoute));
      Severity: Major
      Found in client/src/components/core/breadcrumbs.jsx - About 45 mins to fix

        Function getByParentId has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          getByParentId: function(parentId, parentType) {
    if (this._parentCollection) {
      if (this._parentCollection._type == parentType && this._parentCollection.get(parentId)) {
        var resources = this.where({
          "parent_id": parentId
        Severity: Minor
        Found in server/src/collections/resourceCollection.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            if (result.status === 200) {
      res.json(result.content);
    }
    else {
      res.sendStatus(404);
        Severity: Minor
        Found in server/src/controllers/rest.js and 2 other locations - About 30 mins to fix
        server/src/controllers/rest.js on lines 24..29
        server/src/controllers/rest.js on lines 33..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            if (result.status === 200) {
      res.json(result.content);
    }
    else {
      res.sendStatus(404);
        Severity: Minor
        Found in server/src/controllers/rest.js and 2 other locations - About 30 mins to fix
        server/src/controllers/rest.js on lines 15..20
        server/src/controllers/rest.js on lines 24..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            if (result.status === 200) {
      res.json(result.content);
    }
    else {
      res.sendStatus(404);
        Severity: Minor
        Found in server/src/controllers/rest.js and 2 other locations - About 30 mins to fix
        server/src/controllers/rest.js on lines 15..20
        server/src/controllers/rest.js on lines 33..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          render: function() {
    // Show message if available
    var msg;
    if (this.state.session.get("msg")) {
      msg = (
        Severity: Minor
        Found in client/src/components/user/signup.jsx - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function(require) {
  /**
   * Removes a module from the cache
   */
  require.uncache = function (moduleName) {
        Severity: Minor
        Found in server/src/helpers/uncache.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function removeResource has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          removeResource: function(type, id) {
    return this.ac("removeResource", function() {
      if (_.has(db, type)) {
        if (db[type].removeResource(id)) {
          return this.resp("200");
        Severity: Minor
        Found in server/src/database/models/resource.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function immutableDataSort has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          immutableDataSort: function(data, key, dir) {
    return data.sort(function (a, b) {
      var first = (dir === "asc") ? a.get(key) : b.get(key);
      var last = (dir === "asc") ? b.get(key) : a.get(key);
        Severity: Minor
        Found in client/src/mixins/dataSort.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function dataSort has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          dataSort: function(data, key, dir) {
    return data.sort(function (a, b) {
      var first = (dir === "asc") ? a[key] : b[key];
      var last = (dir === "asc") ? b[key] : a[key];
        Severity: Minor
        Found in client/src/mixins/dataSort.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language