Sign upLogin

WeAreFarmGeek/diplomat

View on GitHub
Star
lib/diplomat/event.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method get has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def get(name = nil, token = :last, not_found = :wait, found = :return, options = {})
      @raw = send_get_request(@conn, ['/v1/event/list'], options, use_named_parameter('name', name))
      body = JSON.parse(@raw.body)
      # TODO: deal with unknown symbols, invalid indices (find_index will return nil)
      idx = case token
Severity: Minor
Found in lib/diplomat/event.rb - About 1 hr to fix

    Method get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def get(name = nil, token = :last, not_found = :wait, found = :return, options = {})
      @raw = send_get_request(@conn, ['/v1/event/list'], options, use_named_parameter('name', name))
      body = JSON.parse(@raw.body)
      # TODO: deal with unknown symbols, invalid indices (find_index will return nil)
      idx = case token
    Severity: Minor
    Found in lib/diplomat/event.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fire has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def fire(name, value = nil, service = nil, node = nil, tag = nil, dc = nil, options = {})
    Severity: Major
    Found in lib/diplomat/event.rb - About 50 mins to fix

      Method get has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get(name = nil, token = :last, not_found = :wait, found = :return, options = {})
      Severity: Minor
      Found in lib/diplomat/event.rb - About 35 mins to fix

        Method get_all has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def get_all(name = nil, not_found = :reject, found = :return, options = {})
      # Event list never returns 404 or blocks, but may return an empty list
      @raw = send_get_request(@conn, ['/v1/event/list'], options, use_named_parameter('name', name))
      if JSON.parse(@raw.body).count.zero?
        case not_found
        Severity: Minor
        Found in lib/diplomat/event.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status