Sign upLogin

WikiEducationFoundation/WikiEduDashboard

View on GitHub
Star
app/assets/javascripts/components/articles/article_list.jsx

Summary

Maintainability
F
3 days
Test Coverage
A
91%

Function render has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const keys = articleListKeys(this.props.course);
    const project = this.props.course.home_wiki.project;
    const trackedEditable = this.props.current_user && this.props.current_user.isAdvancedRole;
Severity: Major
Found in app/assets/javascripts/components/articles/article_list.jsx - About 6 hrs to fix

    File article_list.jsx has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
import PropTypes from 'prop-types';
import createReactClass from 'create-react-class';
import { bindActionCreators } from 'redux';
import { connect } from 'react-redux';
    Severity: Minor
    Found in app/assets/javascripts/components/articles/article_list.jsx - About 2 hrs to fix

      Function render has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        render() {
    const keys = articleListKeys(this.props.course);
    const project = this.props.course.home_wiki.project;
    const trackedEditable = this.props.current_user && this.props.current_user.isAdvancedRole;
      Severity: Minor
      Found in app/assets/javascripts/components/articles/article_list.jsx - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getInitialState has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        getInitialState() {
    // getting filters from the URL
    const { wiki, newness, tracked } = parse(this.props.router.location.search);

    // filter by "wiki"
      Severity: Minor
      Found in app/assets/javascripts/components/articles/article_list.jsx - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (this.props.newnessFilterEnabled) {
      filterArticlesSelect = (
        <select
          className="filter-articles"
          value={this.props.newnessFilter}
      Severity: Major
      Found in app/assets/javascripts/components/articles/article_list.jsx and 1 other location - About 5 hrs to fix
      app/assets/javascripts/components/articles/article_list.jsx on lines 240..252

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 148.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (this.props.trackedStatusFilterEnabled) {
      filterTracked = (
        <select
          className="filter-articles"
          value={this.props.trackedStatusFilter}
      Severity: Major
      Found in app/assets/javascripts/components/articles/article_list.jsx and 1 other location - About 5 hrs to fix
      app/assets/javascripts/components/articles/article_list.jsx on lines 225..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 148.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        propTypes: {
    articles: PropTypes.array,
    course: PropTypes.object,
    current_user: PropTypes.object,
    actions: PropTypes.object,
      Severity: Major
      Found in app/assets/javascripts/components/articles/article_list.jsx and 1 other location - About 1 hr to fix
      app/assets/javascripts/components/common/list.jsx on lines 157..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        onNewnessChange(e) {
    this.updateParams('newness', e.target.value);
    return this.props.filterNewness(e.target.value);
  },
      Severity: Minor
      Found in app/assets/javascripts/components/articles/article_list.jsx and 1 other location - About 50 mins to fix
      app/assets/javascripts/components/articles/article_list.jsx on lines 96..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        onTrackedFilterChange(e) {
    this.updateParams('tracked', e.target.value);
    return this.props.filterTrackedStatus(e.target.value);
  },
      Severity: Minor
      Found in app/assets/javascripts/components/articles/article_list.jsx and 1 other location - About 50 mins to fix
      app/assets/javascripts/components/articles/article_list.jsx on lines 91..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status