WikiEducationFoundation/WikiEduDashboard

View on GitHub
app/assets/javascripts/components/articles/wp10_graph.jsx

Summary

Maintainability
D
1 day
Test Coverage
F
33%

Function Wp10Graph has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Wp10Graph = (props) => {
  useEffect(() => {
    renderGraph();
  }, []);

Severity: Major
Found in app/assets/javascripts/components/articles/wp10_graph.jsx - About 4 hrs to fix

    Function renderGraph has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const renderGraph = () => {
        const vegaSpec = {
          width: props.graphWidth,
          height: props.graphHeight,
          padding: 5,
    Severity: Major
    Found in app/assets/javascripts/components/articles/wp10_graph.jsx - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            axes: [
              {
                orient: 'bottom',
                scale: 'x',
                grid: true,
      Severity: Major
      Found in app/assets/javascripts/components/articles/wp10_graph.jsx and 1 other location - About 1 hr to fix
      app/assets/javascripts/components/articles/edit_size_graph.jsx on lines 43..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            data: [
              {
                name: 'wp10_scores',
                values: props.articleData,
                format: { type: 'json', parse: { date: 'date', wp10: 'number' } },
      Severity: Major
      Found in app/assets/javascripts/components/articles/wp10_graph.jsx and 1 other location - About 1 hr to fix
      app/assets/javascripts/components/articles/edit_size_graph.jsx on lines 63..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                name: 'x',
                type: 'time',
                domain: {
                  data: 'wp10_scores',
      Severity: Minor
      Found in app/assets/javascripts/components/articles/wp10_graph.jsx and 1 other location - About 55 mins to fix
      app/assets/javascripts/components/user_profiles/graphs/as_instructor_graphs/students_taught_graph.jsx on lines 13..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

      Wp10Graph.propTypes = {
        graphid: PropTypes.string,
        graphWidth: PropTypes.number,
        graphHeight: PropTypes.number,
        articleData: PropTypes.array
      Severity: Major
      Found in app/assets/javascripts/components/articles/wp10_graph.jsx and 13 other locations - About 40 mins to fix
      app/assets/javascripts/components/activity/recent_edits_handler.jsx on lines 49..54
      app/assets/javascripts/components/activity/recent_uploads_handler.jsx on lines 38..43
      app/assets/javascripts/components/articles/available_article.jsx on lines 113..118
      app/assets/javascripts/components/articles/available_articles.jsx on lines 106..111
      app/assets/javascripts/components/articles/course_quality_progress_graph.jsx on lines 325..330
      app/assets/javascripts/components/articles/edit_size_graph.jsx on lines 157..162
      app/assets/javascripts/components/common/article_viewer_legend.jsx on lines 75..80
      app/assets/javascripts/components/common/course_link.jsx on lines 15..20
      app/assets/javascripts/components/common/course_navbar.jsx on lines 101..106
      app/assets/javascripts/components/enroll/advice_modal.jsx on lines 59..64
      app/assets/javascripts/components/nav/CustomLink.jsx on lines 14..19
      app/assets/javascripts/components/user_profiles/graphs/as_instructor_graphs/courses_taught_graph.jsx on lines 117..122
      app/assets/javascripts/components/user_profiles/graphs/as_instructor_graphs/students_taught_graph.jsx on lines 114..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status