WikiEducationFoundation/WikiEduDashboard

View on GitHub
app/assets/javascripts/components/common/date_picker.jsx

Summary

Maintainability
D
2 days
Test Coverage
C
74%

Function render has 116 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const spacer = this.props.spacer || ': ';
    let label;
    let timeLabel;
    let currentMonth;
Severity: Major
Found in app/assets/javascripts/components/common/date_picker.jsx - About 4 hrs to fix

    Function render has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

      render() {
        const spacer = this.props.spacer || ': ';
        let label;
        let timeLabel;
        let currentMonth;
    Severity: Minor
    Found in app/assets/javascripts/components/common/date_picker.jsx - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File date_picker.jsx has 286 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
    import createReactClass from 'create-react-class';
    import PropTypes from 'prop-types';
    import DayPicker from 'react-day-picker';
    import OnClickOutside from 'react-onclickoutside';
    Severity: Minor
    Found in app/assets/javascripts/components/common/date_picker.jsx - About 2 hrs to fix

      DatePicker has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      const DatePicker = createReactClass({
        displayName: 'DatePicker',
      
        propTypes: {
          id: PropTypes.string,
      Severity: Minor
      Found in app/assets/javascripts/components/common/date_picker.jsx - About 2 hrs to fix

        Function isDayDisabled has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          isDayDisabled(currentDate) {
            if (this.props.date_props) {
              const minDate = startOfDay(this.props.date_props.minDate);
              if (isValid(minDate) && isAfter(minDate, currentDate)) {
                return true;
        Severity: Minor
        Found in app/assets/javascripts/components/common/date_picker.jsx - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          handleHourFieldChange(e) {
            if (this.state.value === '') {
              this.handleDatePickerChange(new Date());
            }
            this.setState({
        Severity: Major
        Found in app/assets/javascripts/components/common/date_picker.jsx and 1 other location - About 1 hr to fix
        app/assets/javascripts/components/common/date_picker.jsx on lines 159..166

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          handleMinuteFieldChange(e) {
            if (this.state.value === '') {
              this.handleDatePickerChange(new Date());
            }
            this.setState({
        Severity: Major
        Found in app/assets/javascripts/components/common/date_picker.jsx and 1 other location - About 1 hr to fix
        app/assets/javascripts/components/common/date_picker.jsx on lines 150..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    <select
                      className={`time-input__hour ${inputClass}`}
                      onChange={this.handleHourFieldChange}
                      value={this.state.hour}
                    >
        Severity: Major
        Found in app/assets/javascripts/components/common/date_picker.jsx and 1 other location - About 1 hr to fix
        app/assets/javascripts/components/common/date_picker.jsx on lines 321..327

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    <select
                      className={`time-input__minute ${inputClass}`}
                      onChange={this.handleMinuteFieldChange}
                      value={this.state.minute}
                    >
        Severity: Major
        Found in app/assets/javascripts/components/common/date_picker.jsx and 1 other location - About 1 hr to fix
        app/assets/javascripts/components/common/date_picker.jsx on lines 313..319

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status