Sign upLogin

WikiEducationFoundation/WikiEduDashboard

View on GitHub
Star
config/initializers/surveys.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method notification has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def notification(survey_id, curr_user=nil)
      if curr_user.nil?
        # if curr_user is nil, then we haven't preloaded the user's notifications
        notifications = user.survey_notifications.completed.includes(survey_assignment: :survey)
      else
Severity: Minor
Found in config/initializers/surveys.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      @question_group = Rapidfire::QuestionGroup.new(question_group_params)
      if @question_group.save
        respond_to do |format|
          if params.key?(:redirect_to_edit)
Severity: Minor
Found in config/initializers/surveys.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_question_params has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def to_question_params
      {
        :type => type,
        :question_group => question_group,
        :question_text  => question_text,
Severity: Minor
Found in config/initializers/surveys.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status