Sign upLogin

WissamSawah/Weather

View on GitHub
Star

Showing 84 of 84 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function weatherCheckActionGet()
    {
        $title = "Check IP (JSON)";
        $page = $this->di->get("page");
        $request = $this->di->get("request");
Severity: Major
Found in src/Weather/JsonWeather.php and 1 other location - About 1 day to fix
src/Weather/JsonWeather.php on lines 67..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 345.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function indexActionPost()
    {
        $title = "Check IP (JSON)";
        $page = $this->di->get("page");
        $request = $this->di->get("request");
Severity: Major
Found in src/Weather/JsonWeather.php and 1 other location - About 1 day to fix
src/Weather/JsonWeather.php on lines 105..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 345.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method indexActionPost has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function indexActionPost()
    {
        $title = "Check IP (JSON)";
        $page = $this->di->get("page");
        $request = $this->di->get("request");
Severity: Minor
Found in src/Weather/JsonWeather.php - About 1 hr to fix

    Method weatherCheckActionGet has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function weatherCheckActionGet()
    {
        $title = "Check IP (JSON)";
        $page = $this->di->get("page");
        $request = $this->di->get("request");
    Severity: Minor
    Found in src/Weather/JsonWeather.php - About 1 hr to fix

      Method multiRequest has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function multiRequest($data, $options = array())
    {
        // array of curl handles
    $curly = array();
    // data to be returned
      Severity: Minor
      Found in src/WeatherRequest/WeatherRequest.php - About 1 hr to fix

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $data["details"] = $details;
        Severity: Minor
        Found in src/Weather/WeatherIpController.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $page->add("weatherjson", $data);
        Severity: Minor
        Found in src/Weather/JsonWeather.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $data["weather"] = $weather;
        Severity: Minor
        Found in src/Weather/JsonWeather.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $data["currentIp"] = $currentIp;
        Severity: Minor
        Found in src/Weather/WeatherIpController.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $data["weather"] = $weather;
        Severity: Minor
        Found in src/Weather/WeatherIpController.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $page->add("index", $data);
        Severity: Minor
        Found in src/Weather/WeatherIpController.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $data["details"] = $details;
        Severity: Minor
        Found in src/Weather/JsonWeather.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Avoid using undefined variables such as '$data' which will lead to PHP notices.
        Open

                $data["currentIp"] = $currentIp;
        Severity: Minor
        Found in src/Weather/JsonWeather.php by phpmd

        UndefinedVariable

        Since: 2.8.0

        Detects when a variable is used that has not been defined before.

        Example

        class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

        Source https://phpmd.org/rules/cleancode.html#undefinedvariable

        Function multiRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function multiRequest($data, $options = array())
    {
        // array of curl handles
    $curly = array();
    // data to be returned
        Severity: Minor
        Found in src/WeatherRequest/WeatherRequest.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid variables with short names like $mh. Configured minimum length is 3.
        Open

            $mh = curl_multi_init();
        Severity: Minor
        Found in src/WeatherRequest/WeatherRequest.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first side effect is on line 24.
        Open

        <?php
        Severity: Minor
        Found in config/commons.php by phpcodesniffer

        Function multiCurlJson has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function multiCurlJson($details)
    {
        $accessKey  = $this->darkKey;
        $multiRequests = [];
        #future weather
        Severity: Minor
        Found in src/Weather/WeatherIpController.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There must be one blank line after the last USE statement; 0 found;
        Open

        use Anax\Commons\ContainerInjectableTrait;
        Severity: Minor
        Found in src/WeatherRequest/WeatherRequest.php by phpcodesniffer

        Function multiCurlJson has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function multiCurlJson($details)
    {
        $accessKey  = $this->darkKey;
        $multiRequests = [];
        #future weather
        Severity: Minor
        Found in src/Weather/JsonWeather.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There must be one blank line after the namespace declaration
        Open

        namespace Aisa\Weather;
        Severity: Minor
        Found in src/Weather/WeatherIp.php by phpcodesniffer
        Severity
        Category
        Status
        Source
        Language