WissamSawah/Weather

View on GitHub

Showing 6 of 84 total issues

Method indexActionPost has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function indexActionPost()
    {
        $title = "Check IP (JSON)";
        $page = $this->di->get("page");
        $request = $this->di->get("request");
Severity: Minor
Found in src/Weather/JsonWeather.php - About 1 hr to fix

    Method weatherCheckActionGet has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function weatherCheckActionGet()
        {
            $title = "Check IP (JSON)";
            $page = $this->di->get("page");
            $request = $this->di->get("request");
    Severity: Minor
    Found in src/Weather/JsonWeather.php - About 1 hr to fix

      Method multiRequest has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function multiRequest($data, $options = array())
          {
              // array of curl handles
          $curly = array();
          // data to be returned
      Severity: Minor
      Found in src/WeatherRequest/WeatherRequest.php - About 1 hr to fix

        Function multiRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function multiRequest($data, $options = array())
            {
                // array of curl handles
            $curly = array();
            // data to be returned
        Severity: Minor
        Found in src/WeatherRequest/WeatherRequest.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function multiCurlJson has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function multiCurlJson($details)
            {
                $accessKey  = $this->darkKey;
                $multiRequests = [];
                #future weather
        Severity: Minor
        Found in src/Weather/WeatherIpController.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function multiCurlJson has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function multiCurlJson($details)
            {
                $accessKey  = $this->darkKey;
                $multiRequests = [];
                #future weather
        Severity: Minor
        Found in src/Weather/JsonWeather.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language