Sign upLogin

WordPress/WordPress

View on GitHub
Star
wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php

Summary

Maintainability
F
4 days
Test Coverage

File class-wp-rest-font-faces-controller.php has 591 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * REST API: WP_REST_Font_Faces_Controller class
 *
 * @package WordPress
Severity: Major
Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 1 day to fix

    Method get_item_schema has 171 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_item_schema() {
        if ( $this->schema ) {
            return $this->add_additional_fields_schema( $this->schema );
        }
    Severity: Major
    Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 6 hrs to fix

      Method register_routes has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_routes() {
        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
            array(
      Severity: Major
      Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 2 hrs to fix

        WP_REST_Font_Faces_Controller has 22 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class WP_REST_Font_Faces_Controller extends WP_REST_Posts_Controller {

    /**
     * The latest version of theme.json schema supported by the controller.
     *
        Severity: Minor
        Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 2 hrs to fix

          Method validate_create_font_face_settings has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function validate_create_font_face_settings( $value, $request ) {
        $settings = json_decode( $value, true );

        // Check settings string is valid JSON.
        if ( null === $settings ) {
          Severity: Major
          Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 2 hrs to fix

            Method create_item has 52 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function create_item( $request ) {
        $font_family = $this->get_parent_font_family_post( $request['font_family_id'] );
        if ( is_wp_error( $font_family ) ) {
            return $font_family;
        }
            Severity: Major
            Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 2 hrs to fix

              Function validate_create_font_face_settings has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function validate_create_font_face_settings( $value, $request ) {
        $settings = json_decode( $value, true );

        // Check settings string is valid JSON.
        if ( null === $settings ) {
              Severity: Minor
              Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function create_item has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function create_item( $request ) {
        $font_family = $this->get_parent_font_family_post( $request['font_family_id'] );
        if ( is_wp_error( $font_family ) ) {
            return $font_family;
        }
              Severity: Minor
              Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return true;
              Severity: Major
              Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $font_face_post;
                Severity: Major
                Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return new WP_Error(
                    'rest_invalid_param',
                    /* translators: 1: Font face source parameter name: "font_face_settings[src]", 2: The invalid src value. */
                    sprintf( __( '%1$s value "%2$s" must be a valid URL or file reference.' ), 'font_face_settings[src]', $src ),
                    array( 'status' => 400 )
                  Severity: Major
                  Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return new WP_Error(
                    'rest_invalid_param',
                    /* translators: 1: File key (e.g. "file-0") in the request data, 2: Font face source parameter name: "font_face_settings[src]". */
                    sprintf( __( 'File %1$s must be used in %2$s.' ), $file, 'font_face_settings[src]' ),
                    array( 'status' => 400 )
                    Severity: Major
                    Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return parent::delete_item( $request );
                      Severity: Major
                      Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 30 mins to fix

                        Function prepare_item_for_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function prepare_item_for_response( $item, $request ) {
        $fields = $this->get_fields_for_response( $request );
        $data   = array();

        if ( rest_is_field_included( 'id', $fields ) ) {
                        Severity: Minor
                        Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function sanitize_font_face_settings( $value ) {
        // Settings arrive as stringified JSON, since this is a multipart/form-data request.
        $settings = json_decode( $value, true );
        $schema   = $this->get_item_schema()['properties']['font_face_settings']['properties'];
                        Severity: Major
                        Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php and 1 other location - About 1 hr to fix
                        wp-includes/rest-api/endpoints/class-wp-rest-font-families-controller.php on lines 151..163

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 101.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 7 locations. Consider refactoring.
                        Open

                            public function get_item_permissions_check( $request ) {
        $post = $this->get_post( $request['id'] );
        if ( is_wp_error( $post ) ) {
            return $post;
        }
                        Severity: Major
                        Found in wp-includes/rest-api/endpoints/class-wp-rest-font-faces-controller.php and 6 other locations - About 55 mins to fix
                        wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php on lines 161..176
                        wp-includes/rest-api/endpoints/class-wp-rest-font-families-controller.php on lines 63..78
                        wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php on lines 180..195
                        wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php on lines 613..629
                        wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php on lines 714..730
                        wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php on lines 846..861

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 98.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status