Sign upLogin

WordPress/WordPress

View on GitHub
Star
wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php

Summary

Maintainability
D
1 day
Test Coverage

Method get_item_schema has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        if ( $this->schema ) {
            return $this->add_additional_fields_schema( $this->schema );
        }
Severity: Major
Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php - About 4 hrs to fix

    File class-wp-rest-post-types-controller.php has 286 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * REST API: WP_REST_Post_Types_Controller class
 *
 * @package WordPress
    Severity: Minor
    Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php - About 2 hrs to fix

      Method prepare_item_for_response has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function prepare_item_for_response( $item, $request ) {
        // Restores the more descriptive, specific name for use within this method.
        $post_type = $item;

        $taxonomies = wp_list_filter( get_object_taxonomies( $post_type->name, 'objects' ), array( 'show_in_rest' => true ) );
      Severity: Major
      Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php - About 2 hrs to fix

        Function prepare_item_for_response has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function prepare_item_for_response( $item, $request ) {
        // Restores the more descriptive, specific name for use within this method.
        $post_type = $item;

        $taxonomies = wp_list_filter( get_object_taxonomies( $post_type->name, 'objects' ), array( 'show_in_rest' => true ) );
        Severity: Minor
        Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method register_routes has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function register_routes() {

        register_rest_route(
            $this->namespace,
            '/' . $this->rest_base,
        Severity: Minor
        Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php - About 1 hr to fix

          Function get_items_permissions_check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function get_items_permissions_check( $request ) {
        if ( 'edit' === $request['context'] ) {
            $types = get_post_types( array( 'show_in_rest' => true ), 'objects' );

            foreach ( $types as $type ) {
          Severity: Minor
          Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function get_items_permissions_check( $request ) {
        if ( 'edit' === $request['context'] ) {
            $types = get_post_types( array( 'show_in_rest' => true ), 'objects' );

            foreach ( $types as $type ) {
          Severity: Major
          Found in wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php and 1 other location - About 1 hr to fix
          wp-includes/rest-api/endpoints/class-wp-rest-post-statuses-controller.php on lines 83..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status