Sign upLogin

XYOracleNetwork/sdk-archivist-nodejs

View on GitHub
Star
src/repository/dynamodb/table/geo.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function constructor has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(tableName = 'xyo-archivist-geohash', region = 'us-east-1') {
    super(tableName, region)
    this.createTableInput = {
      AttributeDefinitions: [
        {
Severity: Minor
Found in src/repository/dynamodb/table/geo.ts - About 1 hr to fix

    Function getByGeohash has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public async getByGeohash(geohash: string, limit: number): Promise<Buffer[]> {
    return new Promise<Buffer[]>((resolve: any, reject: any) => {
      try {
        const params: DynamoDB.Types.QueryInput = {
          ExpressionAttributeValues: {
    Severity: Minor
    Found in src/repository/dynamodb/table/geo.ts - About 1 hr to fix

      Function putItem has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public async putItem(geohash: string, hash: Buffer): Promise<void> {
    return new Promise<void>((resolve: any, reject: any) => {
      try {
        const params: DynamoDB.Types.PutItemInput = {
          Item: {
      Severity: Minor
      Found in src/repository/dynamodb/table/geo.ts - About 1 hr to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                this.dynamodb.putItem(
          params,
          (err: any, _data: DynamoDB.Types.PutItemOutput) => {
            if (err) {
              reject(err)
        Severity: Major
        Found in src/repository/dynamodb/table/geo.ts and 2 other locations - About 1 hr to fix
        src/repository/dynamodb/table/publickey.ts on lines 73..81
        src/repository/dynamodb/table/time.ts on lines 60..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status