Sign upLogin

XYOracleNetwork/sdk-ble-android

View on GitHub
Star
ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt

Summary

Maintainability
C
1 day
Test Coverage

File XYSmartScan.kt has 256 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package network.xyo.ble.generic.scanner

import android.bluetooth.BluetoothAdapter
import android.bluetooth.BluetoothManager
import android.bluetooth.le.ScanCallback
Severity: Minor
Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt - About 2 hrs to fix

    Method onScanResult has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        internal fun onScanResult(scanResults: List<XYScanResult>): List<XYScanResult> {
        updateLastScannerActivityTimes()
        scanResultCount += scanResults.size
        for (scanResult in scanResults) {
            val foundDevices = HashMap<String, XYBluetoothDevice>()
    Severity: Minor
    Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private fun reportExited(device: XYBluetoothDevice) {
        // log.info("reportExited")
        synchronized(listeners) {
            for ((_, listener) in listeners) {
                ble.launch {
      Severity: Major
      Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt and 2 other locations - About 1 hr to fix
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt on lines 273..282
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt on lines 295..304

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private fun reportDetected(device: XYBluetoothDevice) {
        // log.info("reportDetected")
        synchronized(listeners) {
            for ((_, listener) in listeners) {
                ble.launch {
      Severity: Major
      Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt and 2 other locations - About 1 hr to fix
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt on lines 273..282
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt on lines 284..293

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          private fun reportEntered(device: XYBluetoothDevice) {
        // log.info("reportEntered")
        synchronized(listeners) {
            for ((_, listener) in listeners) {
                ble.launch {
      Severity: Major
      Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt and 2 other locations - About 1 hr to fix
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt on lines 284..293
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt on lines 295..304

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          fun addListener(key: String, listener: XYSmartScanListener) {
        ble.launch {
            synchronized(listeners) {
                listeners[key] = listener
            }
      Severity: Minor
      Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt and 1 other location - About 55 mins to fix
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/reporters/XYBluetoothDeviceReporter.kt on lines 12..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          fun removeListener(key: String) {
        ble.launch {
            synchronized(listeners) {
                listeners.remove(key)
            }
      Severity: Minor
      Found in ble-android-library/src/main/kotlin/network/xyo/ble/generic/scanner/XYSmartScan.kt and 1 other location - About 45 mins to fix
      ble-android-library/src/main/kotlin/network/xyo/ble/generic/reporters/XYBluetoothDeviceReporter.kt on lines 20..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status