Sign upLogin

XYOracleNetwork/sdk-ble-flutter

View on GitHub
Star
android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt

Summary

Maintainability
B
5 hrs
Test Coverage

Method fromBase58 has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

/**
 * Decodes the base58 string into a [ByteArray]
 *
 * @return the decoded data bytes
 * @throws NumberFormatException if the string is not a valid base58 string
Severity: Minor
Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt - About 1 hr to fix

    Method toBase58String has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    /**
 * Encodes the bytes as a base58 string (no checksum is appended).
 *
 * @return the base58-encoded string
 */
    Severity: Minor
    Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          while (zeros < input.size && input[zeros].toInt() == 0) {
        ++zeros
    }
      Severity: Minor
      Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt and 2 other locations - About 35 mins to fix
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 91..93
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 105..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          while (outputStart < decoded.size && decoded[outputStart].toInt() == 0) {
        ++outputStart
    }
      Severity: Minor
      Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt and 2 other locations - About 35 mins to fix
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 43..45
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 91..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          while (zeros < input58.size && input58[zeros].toInt() == 0) {
        ++zeros
    }
      Severity: Minor
      Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt and 2 other locations - About 35 mins to fix
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 43..45
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 105..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              encoded[--outputStart] = alphabet[divmod(input, inputStart.toUInt(), 256.toUInt(), 58.toUInt()).toInt()]
      Severity: Minor
      Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt and 1 other location - About 30 mins to fix
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 99..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              decoded[--outputStart] = divmod(input58, inputStart.toUInt(), 58.toUInt(), 256.toUInt()).toByte()
      Severity: Minor
      Found in android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt and 1 other location - About 30 mins to fix
      android/src/main/kotlin/network/xyo/ble/xyo_ble/Base58.kt on lines 51..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status