XYOracleNetwork/sdk-xyo-client-swift

View on GitHub

Showing 24 of 24 total issues

Avoid too many return statements within this function.
Open

    return "unknown"
Severity: Major
Found in Sources/XyoClient/XyoWitness/SystemInfo/OsName.swift - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return ssids.first
    Severity: Major
    Found in Sources/XyoClient/XyoWitness/SystemInfo/WifiInformation.swift - About 30 mins to fix

      Function report has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public func report(_ adhocWitnesses: [XyoWitness], _ closure: XyoPanelReportCallback?) throws {
              var witnesses: [XyoWitness] = []
              witnesses.append(contentsOf: adhocWitnesses)
              witnesses.append(contentsOf: self._witnesses)
              let payloads = witnesses.map { witness in
      Severity: Minor
      Found in Sources/XyoClient/XyoPanel.swift - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ssid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          func ssid() -> String? {
              var ssid: String?
              if let interfaces = CNCopySupportedInterfaces() as NSArray? {
                  for interface in interfaces {
                      if let interfaceInfo = CNCopyCurrentNetworkInfo(interface as! CFString) as NSDictionary? {
      Severity: Minor
      Found in Sources/XyoClient/XyoWitness/SystemInfo/WifiInformation.swift - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language