Sign upLogin

XYOracleNetwork/sdk-xyo-swift

View on GitHub
Star
Carthage/Checkouts/promises/Sources/Promises/Promise+All.swift

Summary

Maintainability
A
2 hrs
Test Coverage

Function all has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

public func all<A, B, C, D>(
  on queue: DispatchQueue = .promises,
  _ promiseA: Promise<A>,
  _ promiseB: Promise<B>,
  _ promiseC: Promise<C>,
Severity: Minor
Found in Carthage/Checkouts/promises/Sources/Promises/Promise+All.swift - About 1 hr to fix

    Function all has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      on queue: DispatchQueue = .promises,
  _ promiseA: Promise<A>,
  _ promiseB: Promise<B>,
  _ promiseC: Promise<C>,
  _ promiseD: Promise<D>
    Severity: Minor
    Found in Carthage/Checkouts/promises/Sources/Promises/Promise+All.swift - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      // Copyright 2018 Google Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at:
      Severity: Minor
      Found in Carthage/Checkouts/promises/Sources/Promises/Promise+All.swift and 1 other location - About 40 mins to fix
      Carthage/Checkouts/promises/Sources/Promises/Promise+Any.swift on lines 1..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status