XYOracleNetwork/sdk-xyo-swift

View on GitHub
Carthage/Checkouts/promises/Sources/Promises/Promise+Retry.swift

Summary

Maintainability
A
2 hrs
Test Coverage

Function retry has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

public func retry<Value>(
  on queue: DispatchQueue = .promises,
  attempts count: Int = __FBLPromiseRetryDefaultAttemptsCount,
  delay interval: TimeInterval = __FBLPromiseRetryDefaultDelayInterval,
  condition predicate: ((_ count: Int, _ error: Error) -> Bool)? = nil,
Severity: Minor
Found in Carthage/Checkouts/promises/Sources/Promises/Promise+Retry.swift - About 1 hr to fix

    Function retry has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      on queue: DispatchQueue = .promises,
      attempts count: Int = __FBLPromiseRetryDefaultAttemptsCount,
      delay interval: TimeInterval = __FBLPromiseRetryDefaultDelayInterval,
      condition predicate: ((_ count: Int, _ error: Error) -> Bool)? = nil,
      _ work: @escaping () throws -> Promise<Value>
    Severity: Minor
    Found in Carthage/Checkouts/promises/Sources/Promises/Promise+Retry.swift - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

        return promise
      Severity: Major
      Found in Carthage/Checkouts/promises/Sources/Promises/Promise+Retry.swift - About 30 mins to fix

        Function retry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        public func retry<Value>(
          on queue: DispatchQueue = .promises,
          attempts count: Int = __FBLPromiseRetryDefaultAttemptsCount,
          delay interval: TimeInterval = __FBLPromiseRetryDefaultDelayInterval,
          condition predicate: ((_ count: Int, _ error: Error) -> Bool)? = nil,
        Severity: Minor
        Found in Carthage/Checkouts/promises/Sources/Promises/Promise+Retry.swift - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status