Sign upLogin

XYOracleNetwork/sdk-xyo-swift

View on GitHub
Star
Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift

Summary

Maintainability
F
4 days
Test Coverage

Function wait has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    func wait(for device: XYBluetoothDevice) {
        // Quick escape if we already have the device and it is connected or it's already connecting
        guard !isConnectedOrConnecting(for: device) else { return }

        // We have lost contact with the device, so we'll do a non-expiring connectiong try
Severity: Minor
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function connect has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    func connect(to device: XYBluetoothDevice) {
        let deviceId = device.id

        print("STEP 1: Trying to connect to \(deviceId.shortId)...")
Severity: Minor
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function connect has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func connect(to device: XYBluetoothDevice) {
        let deviceId = device.id

        print("STEP 1: Trying to connect to \(deviceId.shortId)...")
Severity: Minor
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 1 hr to fix

    Function wait has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func wait(for device: XYBluetoothDevice) {
        // Quick escape if we already have the device and it is connected or it's already connecting
        guard !isConnectedOrConnecting(for: device) else { return }

        // We have lost contact with the device, so we'll do a non-expiring connectiong try
    Severity: Minor
    Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 1 hr to fix

      Function disconnect has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          func disconnect(from device: XYBluetoothDevice) {
        print("STEP 1: Trying to DISCONNECT from \(device.id.shortId)...")

        let disconnectQueue = DispatchQueue(label: "com.xyfindables.sdk.ConnectionManagerDisconnectQueueFor\(device.id)")
      Severity: Minor
      Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                          return
      Severity: Major
      Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        import CoreBluetooth

public final class XYDeviceConnectionManager {

    public static let instance = XYDeviceConnectionManager()
        Severity: Major
        Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift and 1 other location - About 3 days to fix
        Carthage/Checkouts/sdk-ble-swift/Source/XYDeviceConnectionManager.swift on lines 9..237

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 1573.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status