Sign upLogin

XaBerr/JATE

View on GitHub
Star
dist/jate/functions/errorHandler.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method jateErrorHandler has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function jateErrorHandler($number, $message, $file, $line) {
    if (!(error_reporting() & $number)) {
      return false;
    }
    ob_end_clean();
Severity: Major
Found in dist/jate/functions/errorHandler.php - About 2 hrs to fix

    Avoid using static access to class 'JException' in method 'jateErrorHandler'.
    Open

        $message = JException::decode($message);
    Severity: Minor
    Found in dist/jate/functions/errorHandler.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The function jateErrorHandler() contains an exit expression.
    Open

        exit(1);
    Severity: Minor
    Found in dist/jate/functions/errorHandler.php by phpmd

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

    Source https://phpmd.org/rules/design.html#exitexpression

    There are no issues that match your filters.

    Category
    Status