XaBerr/JUICE

View on GitHub
JATE/dist/jate/functions/requirer.php

Summary

Maintainability
A
1 hr
Test Coverage

Function requireComponents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  function requireComponents( $_path, $_local = true ) {
    $path = getJFolder($_path, $_local, debug_backtrace());
    if(file_exists($path)) {
      $files = subFolderFile($path);
      foreach ($files as $i)
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function requireModulesList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  function requireModulesList( $_path ) {
    if(!file_exists($_path))
      return;
    $data = file_get_contents($_path);
    $data = json_decode($data);
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method requireComponent has a boolean flag argument $_local, which is a certain sign of a Single Responsibility Principle violation.
Open

  function requireComponent( $_path, $_local = true ) {
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '54', column '17').
Open

      throw new Exception("Error in the file format [$_path]", 1);
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method requireComponents has a boolean flag argument $_local, which is a certain sign of a Single Responsibility Principle violation.
Open

  function requireComponents( $_path, $_local = true ) {
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method jRequire has a boolean flag argument $_local, which is a certain sign of a Single Responsibility Principle violation.
Open

  function jRequire( $_path, $_local = true ) {
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method requireModules has a boolean flag argument $_local, which is a certain sign of a Single Responsibility Principle violation.
Open

  function requireModules( $_path, $_local = true ) {
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method requireModulesList uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

      else {
        $path = getJFolder($item, false, debug_backtrace());
        requireComponents("$path", false);
      }
Severity: Minor
Found in JATE/dist/jate/functions/requirer.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

There are no issues that match your filters.

Category
Status