Sign upLogin

Xenapto/ssh-shell

View on GitHub
Star

Showing 2 of 2 total issues

Class Shell has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class Net::SSH::Shell
  attr_reader :session
  attr_reader :channel
  attr_reader :state
  attr_reader :shell
Severity: Minor
Found in lib/net/ssh/shell.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def run
      if state == :new
        state = :starting
        manager.open do
          state = :running
    Severity: Minor
    Found in lib/net/ssh/shell/process.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language