Sign upLogin

XingFramework/xing-frontend-utils

View on GitHub
Star
src/xing-frontend-utils/components/toast/interimElement.js

Summary

Maintainability
D
2 days
Test Coverage

Function InterimElementFactory has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function InterimElementFactory($q, $rootScope, $timeout, $rootElement, $animate, $xngCompiler) {

  return function createInterimElementService(defaults) {

    /**
Severity: Major
Found in src/xing-frontend-utils/components/toast/interimElement.js - About 3 hrs to fix

    Function createInterimElementService has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function createInterimElementService(defaults) {

    /**
     * @ngdoc service
     * @name $$interimElement.$service
    Severity: Major
    Found in src/xing-frontend-utils/components/toast/interimElement.js - About 3 hrs to fix

      Function InterimElementFactory has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      function InterimElementFactory($q, $rootScope, $timeout, $rootElement, $animate, $xngCompiler) {

  return function createInterimElementService(defaults) {

    /**
      Severity: Minor
      Found in src/xing-frontend-utils/components/toast/interimElement.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function InterimElement has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function InterimElement(options) {
      var self;
      var hideTimeout, element;

      options = options || {};
      Severity: Minor
      Found in src/xing-frontend-utils/components/toast/interimElement.js - About 1 hr to fix

        Function InterimElementFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function InterimElementFactory($q, $rootScope, $timeout, $rootElement, $animate, $xngCompiler) {
        Severity: Minor
        Found in src/xing-frontend-utils/components/toast/interimElement.js - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  show: function() {
          return $xngCompiler.compile(options).then(function(compiledData) {
            element = compiledData.link(options.scope);
            var ret = options.onShow(options.scope, element, options);
            return $q.when(ret)
          Severity: Major
          Found in src/xing-frontend-utils/components/toast/interimElement.js and 1 other location - About 4 hrs to fix
          dist/xing-frontend-utils.js on lines 3316..3328

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 127.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              function show(options) {
      if (stack.length) {
        service.hide();
      }
          Severity: Major
          Found in src/xing-frontend-utils/components/toast/interimElement.js and 1 other location - About 2 hrs to fix
          dist/xing-frontend-utils.js on lines 3247..3257

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  remove: function() {
          self.cancelTimeout();
          var ret = options.onRemove(options.scope, element, options);
          return $q.when(ret).then(function() {
            options.scope.$destroy();
          Severity: Major
          Found in src/xing-frontend-utils/components/toast/interimElement.js and 1 other location - About 1 hr to fix
          dist/xing-frontend-utils.js on lines 3335..3341

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              function hide(success) {
      var interimElement = stack.shift();
      interimElement.remove().then(function() {
        interimElement.deferred.resolve(success);
      });
          Severity: Major
          Found in src/xing-frontend-utils/components/toast/interimElement.js and 3 other locations - About 1 hr to fix
          dist/xing-frontend-utils.js on lines 3272..3277
          dist/xing-frontend-utils.js on lines 3292..3297
          src/xing-frontend-utils/components/toast/interimElement.js on lines 135..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              function cancel(reason) {
      var interimElement = stack.shift();
      interimElement.remove().then(function() {
        interimElement.deferred.reject(reason);
      });
          Severity: Major
          Found in src/xing-frontend-utils/components/toast/interimElement.js and 3 other locations - About 1 hr to fix
          dist/xing-frontend-utils.js on lines 3272..3277
          dist/xing-frontend-utils.js on lines 3292..3297
          src/xing-frontend-utils/components/toast/interimElement.js on lines 115..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status