Sign upLogin

XingFramework/xing-frontend-utils

View on GitHub
Star
src/xing-frontend-utils/components/toast/swipe.js

Summary

Maintainability
D
2 days
Test Coverage

Function SwipeService has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      return function SwipeService(scope, eventTypes) {
        if ( !eventTypes ) { eventTypes = "swipeleft swiperight"; }

        // publish configureFor() method for specific element instance
        return function configureFor(element, onSwipeCallback, attachLater ) {
Severity: Minor
Found in src/xing-frontend-utils/components/toast/swipe.js - About 1 hr to fix

    Function configureFor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            return function configureFor(element, onSwipeCallback, attachLater ) {
          var hammertime = new Hammer(element[0], {
            recognizers : addRecognizers([], eventTypes )
          });
    Severity: Minor
    Found in src/xing-frontend-utils/components/toast/swipe.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            return function SwipeService(scope, eventTypes) {
        if ( !eventTypes ) { eventTypes = "swipeleft swiperight"; }

        // publish configureFor() method for specific element instance
        return function configureFor(element, onSwipeCallback, attachLater ) {
      Severity: Major
      Found in src/xing-frontend-utils/components/toast/swipe.js and 1 other location - About 2 days to fix
      dist/xing-frontend-utils.js on lines 3395..3468

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 375.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status