XoopsModules25x/apcal

File events.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.

Consider simplifying this complex logical expression.

Open

if (isset($_POST['delete'])) {

    // Ticket Check
    if (!$xoopsGTicket->check()) {
        redirect_header(XOOPS_URL . '/', 3, $xoopsGTicket->getErrors());

Similar blocks of code found in 2 locations. Consider refactoring.

Open

if (isset($_POST['delete'])) {

    // Ticket Check
    if (!$xoopsGTicket->check()) {
        redirect_header(XOOPS_URL . '/', 3, $xoopsGTicket->getErrors());

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

switch ($tz) {
    case 's':
        $tzoffset  = 0;
        $tzdisp    = ($serverTZ >= 0 ? '+' : '-') . sprintf('%02d:%02d', abs($serverTZ), abs($serverTZ) * 60 % 60);
        $tzoptions = str_replace("'s'>", "'s' selected>", $tzoptions);

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if ($event->allday) {
        $start_desc = date(_AM_APCAL_DTFMT_LIST_ALLDAY, $event->start) . '<br>(' . _APCAL_MB_ALLDAY_EVENT . ')';
        $end_desc   = date(_AM_APCAL_DTFMT_LIST_ALLDAY, $event->end - 300) . '<br>(' . _APCAL_MB_ALLDAY_EVENT . ')';
    } else {
        $start_desc = date(_AM_APCAL_DTFMT_LIST_NORMAL, $event->start + $tzoffset);

• Read up
  Read up

Blank line found at start of control structure

Open

if (isset($_POST['delete'])) {

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

} elseif (isset($_POST['addlink']) && isset($_POST['ids']) && is_array($_POST['ids']) && $_POST['cid'] > 0) {

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

) {

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

} elseif (isset($_POST['output_ics_confirm']) && !empty($_POST['ids']) && is_array($_POST['ids'])) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 135 characters

Open

<form class='apcalForm' id='MainForm' name='MainForm' action='?tz=$tz&amp;num=$num&amp;cid=$cid' method='post' style='margin-top:0px;'>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 183 characters

Open

    <th><input type='checkbox' name='dummy' onclick=\"with(document.MainForm){for (i=0;i<length;i++) {if (elements[i].type=='checkbox') {elements[i].checked=this.checked;}}}\" /></th>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 129 characters

Open

    $sql = "UPDATE $cal->table SET categories=CONCAT(categories,'$cid4sql') WHERE ($whr 0) AND categories NOT LIKE '%$cid4sql%'";

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 132 characters

Open

$nav      = new XoopsPageNav($numrows, $num, $pos, 'pos', "cid=$cid&tz=$tz&num=$num&pf=$pf&txt=" . urlencode($txt));

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 171 characters

Open

$cat_selbox4extract = str_replace("<option value='0'>", "<option value='0'>" . _ALL . "</option>\n<option value='-1'" . ($cid == -1 ? 'selected' : '') . '>', $cat_selbox);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 170 characters

Open

<p><style='color: blue; '>" . (isset($_GET['mes']) ? htmlspecialchars($_GET['mes'], ENT_QUOTES) : '') . "</style></p>\n" . (isset($confirm_html) ? $confirm_html : '') . "

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 206 characters

Open

    <td class='$oddeven' align='right'><a href='$mod_url/index.php?action=Edit&amp;event_id=$event->id' target='_blank'><img src='$cal->images_url/addevent.gif' border='0' width='14' height='12' /></a></td>

• Exclude checks
  • Disable engine
  • Disable check