Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star
include/read_configs.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$from'.
Open

    function mb_convert_encoding($str, $from, $to = 'auto')
Severity: Minor
Found in include/read_configs.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$to'.
Open

    function mb_convert_encoding($str, $from, $to = 'auto')
Severity: Minor
Found in include/read_configs.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method mb_strcut uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return substr($str, $start, $len);
        }
Severity: Minor
Found in include/read_configs.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid variables with short names like $to. Configured minimum length is 3.
Open

    function mb_convert_encoding($str, $from, $to = 'auto')
Severity: Minor
Found in include/read_configs.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 246 and the first side effect is on line 22.
Open

<?php
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Blank line found at start of control structure
Open

        if ($users_authority & 256) {
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Blank line found at start of control structure
Open

    if ($isadmin) {
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Blank line found at start of control structure
Open

    } else {
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 137 characters
Open

$rs = $GLOBALS['xoopsDB']->query('SELECT conf_name,conf_value FROM ' . $GLOBALS['xoopsDB']->prefix('config') . " WHERE conf_modid=$mid");
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

$rs = $GLOBALS['xoopsDB']->query('SELECT mid FROM ' . $GLOBALS['xoopsDB']->prefix('modules') . " WHERE dirname='$moduleDirName'");
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 152 characters
Open

        $sql             = "SELECT cid,pid,cat_shorttitle,cat_title,cat_desc,color,ismenuitem,cat_depth,canbemain FROM $cal->cat_table ORDER BY weight";
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 162 characters
Open

                           . " ON cid=gperm_itemid WHERE gperm_name='apcal_cat' AND gperm_modid='$mid' AND enabled AND gperm_groupid IN $ids4sql ORDER BY weight";
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 136 characters
Open

    $sql             = "SELECT distinct cid,pid,cat_title,cat_desc,color,ismenuitem,cat_depth,canbemain FROM $cal->cat_table LEFT JOIN "
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 155 characters
Open

        $sql             = "SELECT distinct cid,pid,cat_shorttitle,cat_title,cat_desc,color,ismenuitem,cat_depth,canbemain FROM $cal->cat_table LEFT JOIN "
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

Line exceeds 120 characters; contains 131 characters
Open

                       . " ON cid=gperm_itemid WHERE gperm_name='apcal_cat' AND gperm_modid='$mid' AND enabled AND gperm_groupid='"
Severity: Minor
Found in include/read_configs.php by phpcodesniffer

There are no issues that match your filters.

Category
Status