apcal_search_base accesses the super-global variable $GLOBALS. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Method apcal_search_base
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
Avoid using undefined variables such as '$skin_folder' which will lead to PHP notices. Open
$cal->images_url = "$mod_url/assets/images/$skin_folder";
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$skin_folder' which will lead to PHP notices. Open
$cal->images_path = "$mod_path/assets/images/$skin_folder";
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Missing class import via use statement (line '64', column '35'). Open
$cal = new APCal_xoops('', $xoopsConfig['language'], true);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid unused local variables such as '$xoopsDB'. Open
global $xoopsConfig, $xoopsDB, $xoopsUser;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$xoopsUser'. Open
global $xoopsConfig, $xoopsDB, $xoopsUser;
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 49 and the first side effect is on line 22. Open
<?php
- Exclude checks
The variable $mod_path is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $mod_path is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $mod_path is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $mod_url is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $mod_url is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $mod_path is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $skin_folder is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $mod_path is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $skin_folder is not named in camelCase. Open
function apcal_search_base($moduleDirName, $keywords, $andor, $limit, $offset, $uid)
{
global $xoopsConfig, $xoopsDB, $xoopsUser;
// setting physical & virtual paths
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}