XoopsModules25x/apcal

View on GitHub

Showing 1,049 of 26,336 total issues

Avoid deeply nested control flow statements.
Open

                if ($counter > 4) {
                    $counter = 0;
                    echo '</tr>';
                    echo '<tr>';
                }
Severity: Major
Found in admin/admin.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if (hs.dragArgs.exp.releaseMask)
                            hs.dragArgs.exp.releaseMask.style.display = 'none';
    Severity: Major
    Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (!hiddenBy) els[i].style[prop] = els[i].origProp;
      Severity: Major
      Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if ($cal->ro_extrainfo5 !== '') {
                            $retList .= "<td class='$classname'>$romextrainfo5</td>";
                        }
        Severity: Major
        Found in ro_regonlinehandler.php - About 45 mins to fix

          Function endElementHandler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function endElementHandler($fname, $tagname, $line)
                  {
                      array_pop($this->whitespace);
          
                      switch ($tagname) {
          Severity: Minor
          Found in include/patTemplate.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                              if (!$lang_updated && $config->getVar('conf_catid') == XOOPS_CONF
                                  && $config->getVar('conf_name') === 'language'
                              ) {
                                  // regenerate admin menu file
                                  $xoopsConfig['language'] = $_POST[$config->getVar('conf_name')];
          Severity: Major
          Found in include/preferences.inc.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    while (next && !hs.isHsAnchor(next)) {
                                        if ((new RegExp('highslide-' + type)).test(next.className || null)) {
                                            if (!next.id) this.a['_' + type + 'Id'] = next.id = 'hsId' + hs.idCounter++;
                                            this[type] = hs.getNode(next.id);
                                            break;
            Severity: Major
            Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          for ($k = 0, $kMax = count($matches[0]); $k <= $kMax; ++$k) {
                                              if ($matches[1][$k] !== '' && !isset($this->variables[$name][$matches[1][$k]])
                                                  && !isset($this->globals[$matches[1][$k]])
                                              ) {
                                                  $unused[] = $matches[0][$k];
              Severity: Major
              Found in include/patTemplate.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if (!$tpl_updated && $config->getVar('conf_catid') == XOOPS_CONF
                                        && $config->getVar('conf_name') === 'template_set'
                                    ) {
                                        // clear cached/compiled files and regenerate them if default theme has been changed
                                        if ($xoopsConfig['template_set'] != $_POST[$config->getVar('conf_name')]) {
                Severity: Major
                Found in include/preferences.inc.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                  if ($cal->ro_extrainfo1 !== '') {
                                      $retList .= "<td class='$classname'>$romextrainfo1</td>";
                                  }
                  Severity: Major
                  Found in ro_regonlinehandler.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if (!$theme_updated && $config->getVar('conf_catid') == XOOPS_CONF
                                            && $config->getVar('conf_name') === 'theme_set'
                                        ) {
                                            $memberHandler = xoops_getHandler('member');
                                            $memberHandler->updateUsersByField('theme', $_POST[$config->getVar('conf_name')]);
                    Severity: Major
                    Found in include/preferences.inc.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                      if (false !== $all_ok || in_array($modversion['category'], $ok_syscats)) {
                                          echo "<td class='$class' align='center' valign='bottom' width='19%'>";
                                          echo "<a href='" . XOOPS_URL . '/modules/system/admin.php?fct=' . $file . "'><b>" . trim($modversion['name']) . "</b></a>\n";
                                          echo '</td>';
                                          ++$counter;
                      Severity: Major
                      Found in admin/admin.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (re[0] == 'hs.expand') hs.push(images, el);
                                                else if (re[0] == 'hs.htmlExpand') hs.push(htmls, el);
                        Severity: Major
                        Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                          } else if (/highslide-image-blur/.test(el.className)) {
                                              el.style.cursor = hs.styleRestoreCursor;
                                          }
                          Severity: Major
                          Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                            if ($cal->ro_extrainfo3 !== '') {
                                                $retList .= "<td class='$classname'>$romextrainfo3</td>";
                                            }
                            Severity: Major
                            Found in ro_regonlinehandler.php - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      for (var key = 0; key < hs.expanders.length; key++) {
                                                          var exp = hs.expanders[key];
                                                          if (exp && exp.a == el) return key;
                                                      }
                              Severity: Major
                              Found in assets/images/js/highslide/highslide-with-html.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                        if (!$ok) {
                                                            ++$i;
                                                        }
                                Severity: Major
                                Found in class/APCal.php - About 45 mins to fix

                                  Function apcal_map_show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      function apcal_map_show($options)
                                      {
                                          global $xoopsConfig, $xoopsDB;
                                  
                                          $original_level = error_reporting(E_ALL ^ E_NOTICE);
                                  Severity: Minor
                                  Found in blocks/apcal_map.php - About 45 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function get_daytype has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                          public function get_daytype($date)
                                          {
                                              preg_match("/^([0-9][0-9]+)[-.\/]?([0-1]?[0-9])[-.\/]?([0-3]?[0-9])$/", $date, $regs);
                                              $year  = (int)$regs[1];
                                              $month = (int)$regs[2];
                                  Severity: Minor
                                  Found in class/APCal.php - About 45 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if ($event->gmlat > 0 || $event->gmlong > 0) {
                                                              $this->gmPoints[$event->id] = array(
                                                                  'summary'   => $event->summary,
                                                                  'gmlat'     => $event->gmlat,
                                                                  'gmlong'    => $event->gmlong,
                                  Severity: Major
                                  Found in class/APCal.php - About 45 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language