Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star

Showing 26,336 of 26,336 total issues

The parameter $notify_callback is not named in camelCase.
Open

        public function update_schedule($set_sql_append = '', $whr_sql_append = '', $notify_callback = null)
        {
            if ($_POST['summary'] === '') {
                $_POST['summary'] = _APCAL_MB_NOSUBJECT;
            }
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $whr_sql_append is not named in camelCase.
Open

        public function delete_schedule_one($whr_sql_append = '')
        {
            if (!empty($_POST['subevent_id'])) {
                $event_id = (int)$_POST['subevent_id'];
                $this->delete_regonline($event_id); // added one line by goffy
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $op. Configured minimum length is 3.
Open

            $op = empty($_GET['op']) ? '' : preg_replace('/[^a-zA-Z0-9_-]/', '', $_GET['op']);
Severity: Minor
Found in class/APCal.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $is_over24 is not named in camelCase.
Open

        public function get_middle_dhi($time, $is_over24 = false)
        {
            $hour_offset = $is_over24 ? 24 : 0;

            $hour4disp = $this->use24 ? $this->hour_names_24[date('G', $time) + $hour_offset] : $this->hour_names_12[date('G', $time) + $hour_offset];
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $is_start_date is not named in camelCase.
Open

        public function get_todays_time_description(
            $start,
            $end,
            $ynj,
            $justify = true,
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $default_hour is not named in camelCase.
Open

        public function get_options_for_hour($default_hour = 0)
        {
            $ret = '';
            for ($h = 0; $h < 24; ++$h) {
                $ret .= $h == $default_hour ? "<option value='$h' selected>" : "<option value='$h'>";
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $border_for_2400 is not named in camelCase.
Open

        public function get_todays_time_description(
            $start,
            $end,
            $ynj,
            $justify = true,
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $date_desc is not named in camelCase.
Open

        public function parse_posted_date($date_desc, $default_unixtime)
        {
            if (!preg_match('#^([0-9][0-9]+)[-./]?([0-1]?[0-9])[-./]?([0-3]?[0-9])$#', $date_desc, $regs)) {
                $unixtime    = $default_unixtime;
                $use_default = true;
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $get_target is not named in camelCase.
Open

        public function get_categories_selform($get_target = '', $smode = null)
        {
            global $xoopsModule;

            if (empty($this->categories)) {
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $border_for_2400 is not named in camelCase.
Open

        public function get_time_desc_for_a_day(
            $event,
            $tzoffset,
            $border_for_2400,
            $justify = true,
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $is_over24 is not named in camelCase.
Open

        public function get_middle_hi($time, $is_over24 = false)
        {
            $hour_offset = $is_over24 ? 24 : 0;

            $hour4disp = $this->use24 ? $this->hour_names_24[date('G', $time) + $hour_offset] : $this->hour_names_12[date('G', $time) + $hour_offset];
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $tz. Configured minimum length is 3.
Open

        public function get_timezone_desc($tz)
Severity: Minor
Found in class/APCal.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $event_id is not named in camelCase.
Open

        public function delete_regonline($event_id)
        {
            //delete data from table apcal_ro_members
            $sql = 'DELETE '
                   . XOOPS_DB_PREFIX
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $default_min is not named in camelCase.
Open

        public function get_options_for_min($default_min = 0)
        {
            $ret = '';
            for ($m = 0; $m < 60; $m += 5) {
                $ret .= $m == $default_min ? "<option value='$m' selected>" : "<option value='$m'>";
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $default_unixtime is not named in camelCase.
Open

        public function parse_posted_date($date_desc, $default_unixtime)
        {
            if (!preg_match('#^([0-9][0-9]+)[-./]?([0-1]?[0-9])[-./]?([0-3]?[0-9])$#', $date_desc, $regs)) {
                $unixtime    = $default_unixtime;
                $use_default = true;
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $is_end_date is not named in camelCase.
Open

        public function get_todays_time_description(
            $start,
            $end,
            $ynj,
            $justify = true,
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $post_target is not named in camelCase.
Open

        public function output_ics_confirm($post_target, $target = '_self')
        {
            // POST�Ǽ�����ä�id�����event_ids����Ȥ���POST����
            $hiddens = '';
            foreach ($_POST['ids'] as $id) {
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $rs. Configured minimum length is 3.
Open

                $rs = $GLOBALS['xoopsDB']->query("SELECT summary AS udtstmp FROM $this->table WHERE id='$event_id'");
Severity: Minor
Found in class/APCal.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $force_http is not named in camelCase.
Open

        public function import_ics_via_fopen($uri, $force_http = true, $user_uri = '')
        {
            if (strlen($uri) < 5) {
                return '-1:';
            }
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $user_uri is not named in camelCase.
Open

        public function import_ics_via_fopen($uri, $force_http = true, $user_uri = '')
        {
            if (strlen($uri) < 5) {
                return '-1:';
            }
Severity: Minor
Found in class/APCal.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Severity
Category
Status
Source
Language