Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star

Showing 26,336 of 26,336 total issues

Avoid variables with short names like $x. Configured minimum length is 3.
Open

    public static function GetPixelColor(&$img, $x, $y)
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $dst_img is not named in camelCase.
Open

    public static function ImageCopyResampleBicubic(
        $dst_img,
        $src_img,
        $dst_x,
        $dst_y,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $src_img is not named in camelCase.
Open

    public static function ImageCopyResampleBicubic(
        $dst_img,
        $src_img,
        $dst_x,
        $dst_y,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $src_w is not named in camelCase.
Open

    public static function ImageCopyResampleBicubic(
        $dst_img,
        $src_img,
        $dst_x,
        $dst_y,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $c4. Configured minimum length is 3.
Open

                    $c4 = imagecolorat($src_img, $siX2, $siY);
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $src_w is not named in camelCase.
Open

    public static function ImageCopyRespectAlpha(
        &$dst_im,
        &$src_im,
        $dst_x,
        $dst_y,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $dst_w is not named in camelCase.
Open

    public static function ImageCopyResampleBicubic(
        $dst_img,
        $src_img,
        $dst_x,
        $dst_y,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $allow_reduce is not named in camelCase.
Open

    public static function ScaleToFitInBox(
        $width,
        $height,
        $maxwidth = null,
        $maxheight = null,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $src_h is not named in camelCase.
Open

    public static function ImageCopyResampleBicubic(
        $dst_img,
        $src_img,
        $dst_x,
        $dst_y,
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $c3. Configured minimum length is 3.
Open

                    $c3 = imagecolorat($src_img, $siX2, $siY2);
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $c1. Configured minimum length is 3.
Open

                    $c1 = imagecolorat($src_img, $siX, $siY2);
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $r. Configured minimum length is 3.
Open

                    $r = (($c1 + $c2 + $c3 + $c4) >> 2) & 0xFF0000;
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $x_size is not named in camelCase.
Open

    public static function ImageCreateFunction($x_size, $y_size)
    {
        $ImageCreateFunction = 'ImageCreate';
        if (phpthumb_functions::gd_version() >= 2.0) {
            $ImageCreateFunction = 'ImageCreateTrueColor';
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $new_width is not named in camelCase.
Open

    public static function ProportionalResize($old_width, $old_height, $new_width = false, $new_height = false)
    {
        $old_aspect_ratio = $old_width / $old_height;
        if (($new_width === false) && ($new_height === false)) {
            return false;
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $y. Configured minimum length is 3.
Open

    public static function GetPixelColor(&$img, $x, $y)
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $sY. Configured minimum length is 3.
Open

            $sY   = $y * $scaleY;
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $new_height is not named in camelCase.
Open

    public static function ProportionalResize($old_width, $old_height, $new_width = false, $new_height = false)
    {
        $old_aspect_ratio = $old_width / $old_height;
        if (($new_width === false) && ($new_height === false)) {
            return false;
Severity: Minor
Found in thumbs/phpthumb.functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $m_lpVer is not named in camelCase.
Open

class CGIFFILEHEADER
{
    public $m_lpVer;
    public $m_nWidth;
    public $m_nHeight;
Severity: Minor
Found in thumbs/phpthumb.gif.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $b. Configured minimum length is 3.
Open

                    $b    = $argb['blue'];
Severity: Minor
Found in thumbs/phpthumb.ico.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $m_nHeight is not named in camelCase.
Open

class CGIFFILEHEADER
{
    public $m_lpVer;
    public $m_nWidth;
    public $m_nHeight;
Severity: Minor
Found in thumbs/phpthumb.gif.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Severity
Category
Status
Source
Language