XoopsModules25x/apcal

Consider simplifying this complex logical expression.

Open

            if (!hs.container) {

                hs.ieLt7 = hs.ie && hs.uaVersion < 7;
                hs.ieLt9 = hs.ie && hs.uaVersion < 9;

Consider simplifying this complex logical expression.

Open

            if (!hs.container) {

                hs.ieLt7 = hs.ie && hs.uaVersion < 7;
                hs.ieLt9 = hs.ie && hs.uaVersion < 9;

Identical blocks of code found in 2 locations. Consider refactoring.

Open

if (!empty($_POST['submit'])) {
    if (!$xoopsGTicket->check(true, 'myblocksadmin')) {
        redirect_header(XOOPS_URL . '/', 3, $xoopsGTicket->getErrors());
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                if (isset($_POST['saveas'])) {
                    $result = $GLOBALS['xoopsDB']->query("SELECT * FROM {$this->pic_table} WHERE event_id={$_POST['event_oldid']}");
                    while ($pic = $GLOBALS['xoopsDB']->fetchObject($result)) {
                        $GLOBALS['xoopsDB']->query("INSERT INTO {$this->pic_table}(event_id, picture, main_pic) VALUES ({$event_id}, '{$pic->picture}', {$pic->main_pic})");
                    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                if (isset($_POST['saveas'])) {
                    $result = $GLOBALS['xoopsDB']->query("SELECT * FROM {$this->pic_table} WHERE event_id={$_POST['event_oldid']}");
                    while ($pic = $GLOBALS['xoopsDB']->fetchObject($result)) {
                        $GLOBALS['xoopsDB']->query("INSERT INTO {$this->pic_table}(event_id, picture, main_pic) VALUES ({$event_id}, '{$pic->picture}', {$pic->main_pic})");
                    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

if (!empty($_POST['submit'])) {
    if (!$xoopsGTicket->check(true, 'myblocksadmin')) {
        redirect_header(XOOPS_URL . '/', 3, $xoopsGTicket->getErrors());
    }

• Read up
  Read up

Function dragHandler has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        dragHandler: function (e) {
            if (!hs.dragArgs) return true;
            if (!e) e = window.event;
            var a = hs.dragArgs, exp = a.exp;
            if (exp.iframe) {

Method delete_regonline has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        public function delete_regonline($event_id)
        {
            //delete data from table apcal_ro_members
            $sql = 'DELETE '
                   . XOOPS_DB_PREFIX

Method apcal_after_schedule_show_tpl has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function apcal_after_schedule_show_tpl($options)
    {
        global $xoopsConfig, $xoopsDB;

        $moduleDirName = empty($options[0]) ? basename(dirname(__DIR__)) : $options[0];

Method load has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function load($data, &$datLen)
    {
        $datLen = 0;

        while (true) {

Method ApacheLookupURIarray has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function ApacheLookupURIarray($filename)
    {
        // apache_lookup_uri() only works when PHP is installed as an Apache module.
        if (php_sapi_name() == 'apache') {
            //$property_exists_exists = function_exists('property_exists');

Method CleanUpURLencoding has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function CleanUpURLencoding($url, $queryseperator = '&')
    {
        if (!preg_match('#^http#i', $url)) {
            return $url;
        }

Identical blocks of code found in 4 locations. Consider refactoring.

Open

            if (this.fadeInOut) {
                hs.setStyles(this.wrapper, {opacity: up ? 0 : 1});
                hs.extend(to.wrapper, {opacity: up});
            }

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

            if (this.fadeInOut) {
                hs.setStyles(this.wrapper, {opacity: up ? 0 : 1});
                hs.extend(to.wrapper, {opacity: up});
            }

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

            if (this.fadeInOut) {
                hs.setStyles(this.wrapper, {opacity: up ? 0 : 1});
                hs.extend(to.wrapper, {opacity: up});
            }

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

            if (this.fadeInOut) {
                hs.setStyles(this.wrapper, {opacity: up ? 0 : 1});
                hs.extend(to.wrapper, {opacity: up});
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (this.slideshow) {
                var c = this.slideshow.controls;
                if (c && hs.getExpander(c) == this) c.parentNode.removeChild(c);
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (this.slideshow) {
                var c = this.slideshow.controls;
                if (c && hs.getExpander(c) == this) c.parentNode.removeChild(c);
            }

• Read up
  Read up

Function dragHandler has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        dragHandler: function (e) {
            if (!hs.dragArgs) return true;
            if (!e) e = window.event;
            var a = hs.dragArgs, exp = a.exp;
            if (exp.iframe) {

Method notify_new_event has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        public function notify_new_event($event_id)
        {
            $rs    = $GLOBALS['xoopsDB']->query("SELECT summary,admission,categories,class,uid,groupid FROM $this->table WHERE id='$event_id'");
            $event = $GLOBALS['xoopsDB']->fetchObject($rs);