Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star

Showing 26,336 of 26,336 total issues

Avoid variables with short names like $xi. Configured minimum length is 3.
Open

        $xi = $yi = 0;
Severity: Minor
Found in include/Text_Diff.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class Text_Diff_Engine_native is not named in CamelCase.
Open

class Text_Diff_Engine_native
{
    /**
     * @param $from_lines
     * @param $to_lines
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The parameter $other_changed is not named in camelCase.
Open

    public function _shiftBoundaries($lines, &$changed, $other_changed)
    {
        $i = 0;
        $j = 0;
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The class Text_Diff_Op is not named in CamelCase.
Open

class Text_Diff_Op
{
    public $orig;
    public $final;
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The property $_ins_suffix is not named in camelCase.
Open

class Text_Diff_Renderer_inline extends Text_Diff_Renderer
{
    /**
     * Number of leading context "lines" to preserve.
     */
Severity: Minor
Found in include/Text_Diff_Renderer_inline.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $x. Configured minimum length is 3.
Open

        $x     = $xoff;
Severity: Minor
Found in include/Text_Diff.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class Text_Diff_Op_delete is not named in CamelCase.
Open

class Text_Diff_Op_delete extends Text_Diff_Op
{
    /**
     * Text_Diff_Op_delete constructor.
     * @param $lines
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $yi. Configured minimum length is 3.
Open

        $xi      = $yi = 1;
Severity: Minor
Found in include/Text_Diff_Renderer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $_block_header is not named in camelCase.
Open

class Text_Diff_Renderer_inline extends Text_Diff_Renderer
{
    /**
     * Number of leading context "lines" to preserve.
     */
Severity: Minor
Found in include/Text_Diff_Renderer_inline.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $total_num is not named in camelCase.
Open

    function apcal_comments_update($event_id, $total_num)
    {
        // record total_num
        global $xoopsDB, $cal;
Severity: Minor
Found in include/comment_functions.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $to. Configured minimum length is 3.
Open

    function mb_convert_encoding($str, $from, $to = 'auto')
Severity: Minor
Found in include/read_configs.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $i. Configured minimum length is 3.
Open

            global $block_arr, $i;
Severity: Minor
Found in blocks/apcal_after_schedule.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $xi. Configured minimum length is 3.
Open

        $xi = $n_from;
Severity: Minor
Found in include/Text_Diff.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $_split_level is not named in camelCase.
Open

class Text_Diff_Renderer_inline extends Text_Diff_Renderer
{
    /**
     * Number of leading context "lines" to preserve.
     */
Severity: Minor
Found in include/Text_Diff_Renderer_inline.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_leading_context_lines is not named in camelCase.
Open

class Text_Diff_Renderer_unified extends Text_Diff_Renderer
{
    /**
     * Number of leading context "lines" to preserve.
     */
Severity: Minor
Found in include/Text_Diff_Renderer_unified.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $cr. Configured minimum length is 3.
Open

        $cr = XOOPS_URL;
Severity: Minor
Found in include/gtickets.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $to_lines is not named in camelCase.
Open

    public function __construct($from_lines, $to_lines, $mapped_from_lines, $mapped_to_lines)
    {
        assert(count($from_lines) == count($mapped_from_lines));
        assert(count($to_lines) == count($mapped_to_lines));
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $y1. Configured minimum length is 3.
Open

            $y1     = $ymid[$n] + 1;
Severity: Minor
Found in include/Text_Diff.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class Text_MappedDiff is not named in CamelCase.
Open

class Text_MappedDiff extends Text_Diff
{
    /**
     * Computes a diff between sequences of strings.
     *
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The parameter $to_lines is not named in camelCase.
Open

    public function diff($from_lines, $to_lines)
    {
        /* Convert the two input arrays into strings for xdiff processing. */
        $from_string = implode("\n", $from_lines);
        $to_string   = implode("\n", $to_lines);
Severity: Minor
Found in include/Text_Diff.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Severity
Category
Status
Source
Language