Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star
language/utf8_tw/blocks.php

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {

define( 'APCAL_BL_LOADED' , 1 ) ;
Severity: Major
Found in language/utf8_tw/blocks.php and 1 other location - About 6 hrs to fix
language/french/blocks.php on lines 1..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 208.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Expected 0 spaces before closing bracket; 1 found
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Space found before comma in function call
Open

define( 'APCAL_BL_LOADED' , 1 ) ;
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Blank line found at end of control structure
Open
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Blank line found at start of control structure
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Expected 1 space after IF keyword; 0 found
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_MONTH','月');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_EVENTS_THEDAY','%s 的事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_MAXITEMS','顯示件數');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_CATSELSUB','子類別也顯示');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_MAXGIFSADAY','設定每日顯示最多幾個事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_JUSTONCEADAYAPLUGIN','每個 plugin 每天僅能顯示一個事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

A closing tag is not permitted at the end of a PHP file
Open

?>
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Expected 0 spaces after opening bracket; 1 found
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Space after opening parenthesis of function call prohibited
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Expected 0 spaces before closing bracket; 1 found
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Space after opening parenthesis of function call prohibited
Open

define( 'APCAL_BL_LOADED' , 1 ) ;
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_YEAR','年');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_JUMP','切換');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_EVENTS_AFTER','%s 以後的事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_EVENTS_THEDAY','%s 的事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Expected 0 spaces before closing bracket; 1 found
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Space after opening parenthesis of function call prohibited
Open

if( defined( 'FOR_XOOPS_LANG_CHECKER' ) || ! defined( 'APCAL_BL_LOADED' ) ) {
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_NEXT_MONTH','下個月');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_JUMP','切換');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_CATSEL','類別鎖定');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_UNTILDAYS','最多顯示 %s 天的事件 (0 為無限制)');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define( 'APCAL_BL_LOADED' , 1 ) ;
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Expected 0 spaces before closing bracket; 1 found
Open

define( 'APCAL_BL_LOADED' , 1 ) ;
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_EVENTS_AFTER','%s 以後的事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_CATSEL','類別鎖定');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_JUSTONCEADAYAPLUGIN','每個 plugin 每天僅能顯示一個事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_PREV_MONTH','上個月');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_PREV_MONTH','上個月');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_YEAR','年');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Line indented incorrectly; expected at least 4 spaces, found 0
Open

define('_MB_APCAL_MONTH','月');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_MAXITEMS','顯示件數');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_UNTILDAYS','最多顯示 %s 天的事件 (0 為無限制)');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

?>
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_NEXT_MONTH','下個月');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_MAXGIFSADAY','設定每日顯示最多幾個事件');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

No space found after comma in function call
Open

define('_MB_APCAL_CATSELSUB','子類別也顯示');
Severity: Minor
Found in language/utf8_tw/blocks.php by phpcodesniffer

There are no issues that match your filters.

Category
Status