Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star
plugins/monthly/news.php

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
Severity: Major
Found in plugins/monthly/news.php and 1 other location - About 1 day to fix
plugins/monthly/bulletin.php on lines 1..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 396.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line exceeds 120 characters; contains 147 characters
Open

        'link'        => XOOPS_URL . "/modules/{$plugin['dirname']}/article.php?storyid=$id&amp;caldate={$this->year}-{$this->month}-$target_date",
Severity: Minor
Found in plugins/monthly/news.php by phpcodesniffer

Line exceeds 120 characters; contains 178 characters
Open

                     . " WHERE ($whr_topic) AND published < UNIX_TIMESTAMP() AND published >= $range_start_s AND published < $range_end_s AND (expired = 0 OR expired > '$now')");
Severity: Minor
Found in plugins/monthly/news.php by phpcodesniffer

There are no issues that match your filters.

Category
Status