Sign upLogin

XoopsModules25x/apcal

View on GitHub
Star
thumbs/phpThumb.php

Summary

Maintainability
D
2 days
Test Coverage

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

SendSaveAsFileHeaderIfNeeded accesses the super-global variable $_GET.
Open

function SendSaveAsFileHeaderIfNeeded()
{
    if (headers_sent()) {
        return false;
    }
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

RedirectToCachedFile accesses the super-global variable $_SERVER.
Open

function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
Severity: Minor
Found in thumbs/phpThumb.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

File phpThumb.php has 637 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
//////////////////////////////////////////////////////////////
//   phpThumb() by James Heinrich <info@silisoftware.com>   //
//        available at http://phpthumb.sourceforge.net      //
//         and/or https://github.com/JamesHeinrich/phpThumb //
Severity: Major
Found in thumbs/phpThumb.php - About 1 day to fix

    Function RedirectToCachedFile has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
    Severity: Minor
    Found in thumbs/phpThumb.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method RedirectToCachedFile has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
    Severity: Major
    Found in thumbs/phpThumb.php - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if (!@$_GET['w'] && !@$_GET['wp'] && !@$_GET['wl'] && !@$_GET['ws'] && !@$_GET['h'] && !@$_GET['hp']
            && !@$_GET['hl']
            && !@$_GET['hs']
        ) {
            // no resizing needed
      Severity: Critical
      Found in thumbs/phpThumb.php - About 2 hrs to fix

        The function RedirectToCachedFile() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Remove error control operator '@' on line 71.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        Remove error control operator '@' on line 79.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        Remove error control operator '@' on line 105.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        Remove error control operator '@' on line 62.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        Remove error control operator '@' on line 116.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        Remove error control operator '@' on line 57.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        The method RedirectToCachedFile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $phpThumb->DebugMessage('* Would have sent data: readfile(' . $phpThumb->cache_filename . ')', __FILE__, __LINE__);
        }
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class 'phpthumb_functions' in method 'RedirectToCachedFile'.
        Open

            $parsed_url = phpthumb_functions::ParseURLbetter(@$_SERVER['HTTP_REFERER']);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method RedirectToCachedFile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

            } else {
        if (headers_sent()) {
            $phpThumb->ErrorImage('Headers already sent (' . basename(__FILE__) . ' line ' . __LINE__ . ')');
            exit;
        }
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '105', column '13').
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class 'phpthumb_functions' in method 'RedirectToCachedFile'.
        Open

                    header('Content-Type: ' . phpthumb_functions::ImageTypeToMIMEtype($getimagesize[2]));
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'phpthumb_functions' in method 'SendSaveAsFileHeaderIfNeeded'.
        Open

            $downloadfilename = phpthumb_functions::SanitizeFilename(!empty($_GET['sia']) ? $_GET['sia'] : (!empty($_GET['down']) ? $_GET['down'] : 'phpThumb_generated_thumbnail.'
                                                                                                                                            . (!empty($_GET['f']) ? $_GET['f'] : 'jpg')));
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method RedirectToCachedFile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            @readfile($phpThumb->cache_filename);
        }
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '79', column '13').
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class 'phpthumb_functions' in method 'RedirectToCachedFile'.
        Open

                    $phpThumb->DebugMessage('* Would have sent headers (2): Content-Type: ' . phpthumb_functions::ImageTypeToMIMEtype($getimagesize[2]), __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The function RedirectToCachedFile() contains an exit expression.
        Open

                exit;
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ExitExpression

        Since: 0.2

        An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

        Example

        class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

        Source https://phpmd.org/rules/design.html#exitexpression

        The function RedirectToCachedFile() contains an exit expression.
        Open

                    exit;
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ExitExpression

        Since: 0.2

        An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

        Example

        class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

        Source https://phpmd.org/rules/design.html#exitexpression

        The function RedirectToCachedFile() contains an exit expression.
        Open

                    exit;
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        ExitExpression

        Since: 0.2

        An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

        Example

        class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

        Source https://phpmd.org/rules/design.html#exitexpression

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 30 and the first side effect is on line 13.
        Open

        <?php
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Blank line found at start of control structure
        Open

        if ($phpThumb->rawImageData) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Blank line found at start of control structure
        Open

                ) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Blank line found at start of control structure
        Open

        } elseif (!empty($_GET['new'])) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Blank line found at start of control structure
        Open

        if (!empty($phpThumb->config_high_security_enabled) && !empty($_GET['nocache'])) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                                            __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 166 characters
        Open

                    if ($rawImageData = phpthumb_functions::SafeURLread($_GET['src'], $error, $phpThumb->config_http_fopen_timeout, $phpThumb->config_http_follow_redirect)) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 165 characters
        Open

                    $phpThumb->DebugMessage('* Would have sent headers (2): Content-Type: ' . phpthumb_functions::ImageTypeToMIMEtype($getimagesize[2]), __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 134 characters
        Open

            $phpThumb->DebugMessage('$CanPassThroughDirectly=false because !@is_file(' . $phpThumb->sourceFilename . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 159 characters
        Open

                    $phpThumb->DebugMessage('SafeURLread(' . $phpThumb->src . ') succeeded' . ($error ? ' with messsages: "' . $error . '"' : ''), __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 122 characters
        Open

                $phpThumb->DebugMessage('PATH_INFO."w"x"h" set to "' . $_GET['w'] . '"x"' . $_GET['h'] . '"', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 159 characters
        Open

                    $phpThumb->DebugMessage('setParameter(' . $key . ', ' . $phpThumb->phpThumbDebugVarDump($value) . ') from $PHPTHUMB_DEFAULTS', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 135 characters
        Open

                $phpThumb->DebugMessage('$phpThumb->src (' . $phpThumb->src . ') is remote image, attempting to download', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 131 characters
        Open

                $phpThumb->DebugMessage('CleanUpURLencoding(' . $phpThumb->src . ') returned "' . $cleanedupurl . '"', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 153 characters
        Open

        $phpThumb->DebugMessage('$CanPassThroughDirectly="' . (int)$CanPassThroughDirectly . '" && $phpThumb->src="' . $phpThumb->src . '"', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 186 characters
        Open

                                                                                                                                                    . (!empty($_GET['f']) ? $_GET['f'] : 'jpg')));
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 171 characters
        Open

                                                                                                                      . '" is not an allowed referer' : 'no HTTP_REFERER exists'));
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 166 characters
        Open

                    //$phpThumb->DebugMessage('PHPTHUMB_DEFAULTS assigning ('.(is_array($value) ? print_r($value, true) : $value).') to $_GET['.$key.']', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 138 characters
        Open

            $phpThumb->DebugMessage('$CanPassThroughDirectly=false because !@is_readable(' . $phpThumb->sourceFilename . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 143 characters
        Open

                    if ($cid = @mysqli_connect($phpThumb->config_mysql_hostname, $phpThumb->config_mysql_username, $phpThumb->config_mysql_password)) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 150 characters
        Open

                ) { // set parameter to default value if config is set to allow _GET to override default, OR if no value is passed via _GET for this parameter
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 139 characters
        Open

                $phpThumb->DebugMessage('Passing HTTP source through directly as Location: redirect (' . $phpThumb->src . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 195 characters
        Open

                    $phpThumb->DebugMessage('Passing "' . $SourceFilename . '" through directly, no resizing required ("' . $phpThumb->getimagesizeinfo[0] . '"x"' . $phpThumb->getimagesizeinfo[1] . '")',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 200 characters
        Open

                        $phpThumb->DebugMessage('Not passing "' . $SourceFilename . '" through directly because $phpThumb->getimagesizeinfo[2] = "' . $phpThumb->getimagesizeinfo[2] . '"', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 140 characters
        Open

                $phpThumb->DebugMessage('Not passing "' . $SourceFilename . '" through directly because GetImageSize() failed', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 164 characters
        Open

                if ($rawImageData = phpthumb_functions::SafeURLread($phpThumb->src, $error, $phpThumb->config_http_fopen_timeout, $phpThumb->config_http_follow_redirect)) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 150 characters
        Open

                $phpThumb->DebugMessage('* Would have sent headers (1): Last-Modified: ' . gmdate('D, d M Y H:i:s', $nModified) . ' GMT', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 139 characters
        Open

                                                                                                                      . $parsed_url_referer['host']
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 127 characters
        Open

                    $phpThumb->DebugMessage('Setting "user_agent" to "' . $phpThumb->config_http_user_agent . '"', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 127 characters
        Open

                    $phpThumb->DebugMessage('* Would have sent data: readfile(' . $phpThumb->cache_filename . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 157 characters
        Open

                $phpThumb->ErrorImage('failed to include_once(' . __DIR__ . '/phpThumb.config.php) - realpath="' . realpath(__DIR__ . '/phpThumb.config.php') . '"');
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 153 characters
        Open

            $phpThumb->ErrorImage('failed to include_once(' . __DIR__ . '/phpThumb.config.php) - realpath="' . realpath(__DIR__ . '/phpThumb.config.php') . '"');
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 132 characters
        Open

            $phpThumb->DebugMessage('setting $PHPTHUMB_DEFAULTS[' . implode(';', array_keys($PHPTHUMB_DEFAULTS)) . ']', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 136 characters
        Open

            $phpThumb->DebugMessage('Cached file "' . $phpThumb->cache_filename . '" does not exist, processing as normal', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 135 characters
        Open

                header('Content-Disposition: ' . (!empty($_GET['down']) ? 'attachment' : 'inline') . '; filename="' . $downloadfilename . '"');
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 121 characters
        Open

                        $phpThumb->ErrorImage('MySQLi connect error (' . $mysqli->connect_errno . ') ' . $mysqli->connect_error);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 131 characters
        Open

                $phpThumb->DebugMessage('ignoring $_GET[' . $key . '] because of $PHPTHUMB_DEFAULTS_DISABLEGETPARAMS', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 144 characters
        Open

            $phpThumb->DebugMessage('$CanPassThroughDirectly=false because preg_match("#^(f|ht)tp\://#i", ' . $phpThumb->src . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 121 characters
        Open

                                            . '" through directly because ($phpThumb->config_disable_onlycreateable_passthru = "'
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 127 characters
        Open

                $new_background_color = phpthumb_functions::ImageHexColorAllocate($phpThumb->gdimg_source, $bghexcolor, false, $alpha);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 169 characters
        Open

                    $mysqli = new mysqli($phpThumb->config_mysql_hostname, $phpThumb->config_mysql_username, $phpThumb->config_mysql_password, $phpThumb->config_mysql_database);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 131 characters
        Open

                $phpThumb->DebugMessage('setParameter(' . $key . ', ' . $phpThumb->phpThumbDebugVarDump($value) . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 199 characters
        Open

                $phpThumb->DebugMessage('Direct passthru GetImageSize() returned [w=' . $phpThumb->getimagesizeinfo[0] . ';h=' . $phpThumb->getimagesizeinfo[1] . ';t=' . $phpThumb->getimagesizeinfo[2] . ']',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 196 characters
        Open

                $phpThumb->DebugMessage('Cannot write to $phpThumb->cache_filename (' . $phpThumb->cache_filename . ') because that directory (' . dirname($phpThumb->cache_filename) . ') is not writable',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 165 characters
        Open

                    $phpThumb->DebugMessage('* Would have sent headers (3): Location: ' . dirname($matches[1]) . '/' . urlencode(basename($matches[1])), __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 196 characters
        Open

            } elseif ($_GET['hash'] != md5(str_replace($phpThumb->config_high_security_url_separator . 'hash=' . $_GET['hash'], '', $_SERVER['QUERY_STRING']) . $phpThumb->config_high_security_password)) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 135 characters
        Open

            $phpThumb->ErrorImage('Usage: ' . $_SERVER['PHP_SELF'] . '?src=/path/and/filename.jpg' . "\n" . 'read Usage comments for details');
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 128 characters
        Open

            $phpThumb->ErrorImage('Error in OutputThumbnail():' . "\n" . $phpThumb->debugmessages[count($phpThumb->debugmessages) - 1]);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 198 characters
        Open

                $phpThumb->DebugMessage('SendSaveAsFileHeaderIfNeeded() sending header: Content-Disposition: ' . (!empty($_GET['down']) ? 'attachment' : 'inline') . '; filename="' . $downloadfilename . '"',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 154 characters
        Open

            $phpThumb->DebugMessage('$CanPassThroughDirectly=false because $_GET[' . implode(';', array_unique($UnAllowedGET)) . '] are set', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 159 characters
        Open

                        $phpThumb->DebugMessage('Would have passed "' . $SourceFilename . '" through directly, but skipping due to phpThumbDebug', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 171 characters
        Open

            $downloadfilename = phpthumb_functions::SanitizeFilename(!empty($_GET['sia']) ? $_GET['sia'] : (!empty($_GET['down']) ? $_GET['down'] : 'phpThumb_generated_thumbnail.'
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 122 characters
        Open

                    $phpThumb->ErrorImage('only FTP and HTTP/HTTPS protocols are allowed, "' . $protocol_matches[1] . '" is not');
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 139 characters
        Open

                    $phpThumb->DebugMessage('setParameter(' . $keyname . ', ' . $phpThumb->phpThumbDebugVarDump($value) . ')', __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Line exceeds 120 characters; contains 193 characters
        Open

                //foreach (array('mysql_connect', 'mysql_select_db', 'mysql_query', 'mysql_fetch_array', 'mysql_free_result', '$GLOBALS['xoopsDB']->close', 'mysql_error') as $required_mysql_function) {
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Closing parenthesis of a multi-line function call must be on a line by itself
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 8 spaces but found 32
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Opening parenthesis of a multi-line function call must be the last content on the line
        Open

                $phpThumb->DebugMessage('Cannot write to $phpThumb->cache_filename (' . $phpThumb->cache_filename . ') because that directory (' . dirname($phpThumb->cache_filename) . ') is not writable',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 12 spaces but found 36
        Open

                                            __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Opening parenthesis of a multi-line function call must be the last content on the line
        Open

                    $phpThumb->DebugMessage('Passing "' . $SourceFilename . '" through directly, no resizing required ("' . $phpThumb->getimagesizeinfo[0] . '"x"' . $phpThumb->getimagesizeinfo[1] . '")',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Closing parenthesis of a multi-line function call must be on a line by itself
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Opening parenthesis of a multi-line function call must be the last content on the line
        Open

                $phpThumb->DebugMessage('Direct passthru GetImageSize() returned [w=' . $phpThumb->getimagesizeinfo[0] . ';h=' . $phpThumb->getimagesizeinfo[1] . ';t=' . $phpThumb->getimagesizeinfo[2] . ']',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Opening parenthesis of a multi-line function call must be the last content on the line
        Open

                $phpThumb->DebugMessage('SendSaveAsFileHeaderIfNeeded() sending header: Content-Disposition: ' . (!empty($_GET['down']) ? 'attachment' : 'inline') . '; filename="' . $downloadfilename . '"',
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Closing parenthesis of a multi-line function call must be on a line by itself
        Open

                                            __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 8 spaces but found 32
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Multi-line function call not indented correctly; expected 8 spaces but found 32
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        Closing parenthesis of a multi-line function call must be on a line by itself
        Open

                                        __FILE__, __LINE__);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpcodesniffer

        The variable $parsed_url is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $parsed_url is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $nice_docroot is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $nice_docroot is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $nice_cachefile is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $nice_docroot is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $nice_cachefile is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $nice_cachefile is not named in camelCase.
        Open

        function RedirectToCachedFile()
{
    global $phpThumb;

    $nice_cachefile = str_replace(DIRECTORY_SEPARATOR, '/', $phpThumb->cache_filename);
        Severity: Minor
        Found in thumbs/phpThumb.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        There are no issues that match your filters.

        Category
        Status