Sign upLogin

XoopsModules25x/contact

View on GitHub
Star

Showing 495 of 495 total issues

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/blocksadmin.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/menu.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Contact\{
Severity: Minor
Found in include/onupdate.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use \XoopsModules\Contact\{
Severity: Minor
Found in header.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/admin_header.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/menu.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/main.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in include/onupdate.php by phpcodesniffer

There must be one blank line after the last USE statement; 3 found;
Open

use XoopsUser;
Severity: Minor
Found in class/Common/FilesManagement.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/blocksadmin.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in send.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/blockform.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/admin_header.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Contact\{
Severity: Minor
Found in admin/main.php by phpcodesniffer

Expected 1 blank line at end of file; 2 found
Open

define('_AM_CONTACT_ERROR_TAG_REMOVAL', 'Konnte Tags vom Modul Tag nicht entfernen');
Severity: Minor
Found in language/german/admin.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use Xmf\Request;
Severity: Minor
Found in admin/tools.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use Xmf\Request;
Severity: Minor
Found in admin/log.php by phpcodesniffer

Scope keyword "public" must be followed by a single space
Open

    public  $dirname;
Severity: Minor
Found in class/Common/Breadcrumb.php by phpcodesniffer

Remove error control operator '@' on line 68.
Open

    public static function recurseCopy($src, $dst)
    {
        $dir = \opendir($src);
        //        @mkdir($dst);
        if (!@\mkdir($dst) && !\is_dir($dst)) {
Severity: Minor
Found in class/Common/FilesManagement.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

The method truncateHtml has a boolean flag argument $exact, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
Severity: Minor
Found in class/Common/SysUtility.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Severity
Category
Status
Source
Language