Sign upLogin

XoopsModules25x/lexikon

View on GitHub
Star
admin/submissions.php

Summary

Maintainability
F
3 days
Test Coverage

File submissions.php has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Module: Lexikon - glossary module
 * Author: hsalazar
 * Changes: Yerres
Severity: Minor
Found in admin/submissions.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($numrows > 0) { // That is, if there ARE submitted entries in the system
            while (list($entryID, $categoryID, $term, $uid, $created) = $xoopsDB->fetchRow($resultS2)) {
                $resultS3 = $xoopsDB->query(
                    'SELECT name
                                           FROM ' . $xoopsDB->prefix('lxcategories') . "
    Severity: Major
    Found in admin/submissions.php and 1 other location - About 1 day to fix
    admin/submissions.php on lines 284..318

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 337.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($numrowsX > 0) { // That is, if there ARE unauthorized articles in the system
            while (list($entryID, $categoryID, $term, $uid, $created) = $xoopsDB->fetchRow($resultS4)) {
                $resultS3 = $xoopsDB->query(
                    'SELECT name
                                             FROM ' . $xoopsDB->prefix('lxcategories') . "
    Severity: Major
    Found in admin/submissions.php and 1 other location - About 1 day to fix
    admin/submissions.php on lines 135..170

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 337.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status