Sign upLogin

XoopsModules25x/mylinks

View on GitHub
Star
admin/main.php

Summary

Maintainability
F
1 wk
Test Coverage

File main.php has 829 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * MyLinks category.php
 *
 * Xoops mylinks - a multicategory links module
Severity: Major
Found in admin/main.php - About 1 day to fix

    Function importCats has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    function importCats()
{
    global $xoopsDB, $xoopsModule, $xoopsConfig, $myts;

    $ok = MylinksUtility::mylinks_cleanVars($_POST, 'ok', 0, 'int', array('min' => 0, 'max' => 1));
    Severity: Minor
    Found in admin/main.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method listModReq has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function listModReq()
{
    global $xoopsDB, $myts, $xoopsModuleConfig, $xoopsModule;

    $result           = $xoopsDB->query('SELECT requestid, lid, cid, title, url, logourl, description, modifysubmitter FROM ' . $xoopsDB->prefix('mylinks_mod') . ' ORDER BY requestid');
    Severity: Major
    Found in admin/main.php - About 3 hrs to fix

      Function delCat has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

      function delCat()
{
    global $xoopsDB, $myCatTree, $xoopsModule, $xoopsUser;

    $cid = MylinksUtility::mylinks_cleanVars($_REQUEST, 'cid', 0, 'int', array('min' => 0));
      Severity: Minor
      Found in admin/main.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function listModReq has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

      function listModReq()
{
    global $xoopsDB, $myts, $xoopsModuleConfig, $xoopsModule;

    $result           = $xoopsDB->query('SELECT requestid, lid, cid, title, url, logourl, description, modifysubmitter FROM ' . $xoopsDB->prefix('mylinks_mod') . ' ORDER BY requestid');
      Severity: Minor
      Found in admin/main.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method modLink has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function modLink()
{
    global $xoopsDB, $myts, $myCatTree, $xoopsModule;

    $linkimg_array = XoopsLists::getImgListAsArray(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/images/shots/');
      Severity: Major
      Found in admin/main.php - About 3 hrs to fix

        Method addLink has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function addLink()
{
    global $xoopsDB, $myts, $xoopsUser, $xoopsModule;

    $cid         = MylinksUtility::mylinks_cleanVars($_POST, 'cid', 0, 'int', array('min' => 0));
        Severity: Major
        Found in admin/main.php - About 2 hrs to fix

          Method delCat has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function delCat()
{
    global $xoopsDB, $myCatTree, $xoopsModule, $xoopsUser;

    $cid = MylinksUtility::mylinks_cleanVars($_REQUEST, 'cid', 0, 'int', array('min' => 0));
          Severity: Major
          Found in admin/main.php - About 2 hrs to fix

            Method listBrokenLinks has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function listBrokenLinks()
{
    global $xoopsDB, $xoopsModule, $pathIcon16, $myts;

    $result           = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('mylinks_broken') . ' GROUP BY lid ORDER BY reportid DESC');
            Severity: Minor
            Found in admin/main.php - About 2 hrs to fix

              Method linksConfigMenu has 49 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function linksConfigMenu()
{
    global $xoopsDB, $myts, $myCatTree, $xoopsModule;

    $mylinksCatHandler = xoops_getModuleHandler('category', $xoopsModule->getVar('dirname'));
              Severity: Minor
              Found in admin/main.php - About 1 hr to fix

                Function listBrokenLinks has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                function listBrokenLinks()
{
    global $xoopsDB, $xoopsModule, $pathIcon16, $myts;

    $result           = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('mylinks_broken') . ' GROUP BY lid ORDER BY reportid DESC');
                Severity: Minor
                Found in admin/main.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method importCats has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function importCats()
{
    global $xoopsDB, $xoopsModule, $xoopsConfig, $myts;

    $ok = MylinksUtility::mylinks_cleanVars($_POST, 'ok', 0, 'int', array('min' => 0, 'max' => 1));
                Severity: Minor
                Found in admin/main.php - About 1 hr to fix

                  Method listNewLinks has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function listNewLinks()
{
    global $xoopsDB, $myts, $myCatTree, $xoopsModule;
    // List links waiting for validation
    $linkimg_array = XoopsLists::getImgListAsArray(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/images/shots/');
                  Severity: Minor
                  Found in admin/main.php - About 1 hr to fix

                    Method approve has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function approve()
{
    global $xoopsDB, $myts, $xoopsModule;

    $lid         = MylinksUtility::mylinks_cleanVars($_POST, 'lid', 0, 'int', array('min' => 0));
                    Severity: Minor
                    Found in admin/main.php - About 1 hr to fix

                      Function changeModReq has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function changeModReq()
{
    global $xoopsDB, $myts;

    $requestid = MylinksUtility::mylinks_cleanVars($_POST, 'requestid', 0, 'int', array('min' => 0));
                      Severity: Minor
                      Found in admin/main.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method changeModReq has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function changeModReq()
{
    global $xoopsDB, $myts;

    $requestid = MylinksUtility::mylinks_cleanVars($_POST, 'requestid', 0, 'int', array('min' => 0));
                      Severity: Minor
                      Found in admin/main.php - About 1 hr to fix

                        Method addCat has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function addCat()
{
    global $xoopsDB, $myts, $xoopsModule;
    $pid    = MylinksUtility::mylinks_cleanVars($_POST, 'pid', 0, 'int', array('min' => 0));
    $title  = MylinksUtility::mylinks_cleanVars($_POST, 'title', '', 'string');
                        Severity: Minor
                        Found in admin/main.php - About 1 hr to fix

                          Method modCatS has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function modCatS()
{
    global $xoopsDB, $myts, $xoopsModule;
    $cid    = MylinksUtility::mylinks_cleanVars($_POST, 'cid', 0, 'int', array('min' => 0));
    $imgurl = MylinksUtility::mylinks_cleanVars($_POST, 'imgurl', '', 'string');
                          Severity: Minor
                          Found in admin/main.php - About 1 hr to fix

                            Method modCat has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function modCat()
{
    global $xoopsDB, $myts, $xoopsModule;

    $cid = MylinksUtility::mylinks_cleanVars($_GET, 'cid', 0, 'int', array('min' => 0));
                            Severity: Minor
                            Found in admin/main.php - About 1 hr to fix

                              Function linksConfigMenu has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function linksConfigMenu()
{
    global $xoopsDB, $myts, $myCatTree, $xoopsModule;

    $mylinksCatHandler = xoops_getModuleHandler('category', $xoopsModule->getVar('dirname'));
                              Severity: Minor
                              Found in admin/main.php - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function addLink has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function addLink()
{
    global $xoopsDB, $myts, $xoopsUser, $xoopsModule;

    $cid         = MylinksUtility::mylinks_cleanVars($_POST, 'cid', 0, 'int', array('min' => 0));
                              Severity: Minor
                              Found in admin/main.php - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function listNewLinks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function listNewLinks()
{
    global $xoopsDB, $myts, $myCatTree, $xoopsModule;
    // List links waiting for validation
    $linkimg_array = XoopsLists::getImgListAsArray(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/images/shots/');
                              Severity: Minor
                              Found in admin/main.php - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function modCatS has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function modCatS()
{
    global $xoopsDB, $myts, $xoopsModule;
    $cid    = MylinksUtility::mylinks_cleanVars($_POST, 'cid', 0, 'int', array('min' => 0));
    $imgurl = MylinksUtility::mylinks_cleanVars($_POST, 'imgurl', '', 'string');
                              Severity: Minor
                              Found in admin/main.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function modLink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function modLink()
{
    global $xoopsDB, $myts, $myCatTree, $xoopsModule;

    $linkimg_array = XoopsLists::getImgListAsArray(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/images/shots/');
                              Severity: Minor
                              Found in admin/main.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function approve has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function approve()
{
    global $xoopsDB, $myts, $xoopsModule;

    $lid         = MylinksUtility::mylinks_cleanVars($_POST, 'lid', 0, 'int', array('min' => 0));
                              Severity: Minor
                              Found in admin/main.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              function ignoreModReq()
{
    global $xoopsDB;

    $requestid = MylinksUtility::mylinks_cleanVars($_POST, 'requestid', 0, 'int', array('min' => 0));
                              Severity: Major
                              Found in admin/main.php and 1 other location - About 1 hr to fix
                              admin/main.php on lines 385..398

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 120.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              function ignoreBrokenLinks()
{
    global $xoopsDB;

    $bknrptid = MylinksUtility::mylinks_cleanVars($_POST, 'bknrptid', 0, 'int', array('min' => 0));
                              Severity: Major
                              Found in admin/main.php and 1 other location - About 1 hr to fix
                              admin/main.php on lines 536..549

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 120.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status