Sign upLogin

XoopsModules25x/mylinks

View on GitHub
Star
include/search.inc.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method mylinks_search has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function mylinks_search($queryarray, $andor, $limit, $offset, $userid)
{
    global $xoopsDB;
    $sql = 'SELECT l.lid,l.cid,l.title,l.submitter,l.date,t.description FROM ' . $xoopsDB->prefix('mylinks_links') . ' l LEFT JOIN ' . $xoopsDB->prefix('mylinks_text') . ' t ON t.lid=l.lid WHERE status>0';
    if ($userid != 0) {
Severity: Minor
Found in include/search.inc.php - About 1 hr to fix

    Method mylinks_search has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function mylinks_search($queryarray, $andor, $limit, $offset, $userid)
    Severity: Minor
    Found in include/search.inc.php - About 35 mins to fix

      Function mylinks_search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function mylinks_search($queryarray, $andor, $limit, $offset, $userid)
{
    global $xoopsDB;
    $sql = 'SELECT l.lid,l.cid,l.title,l.submitter,l.date,t.description FROM ' . $xoopsDB->prefix('mylinks_links') . ' l LEFT JOIN ' . $xoopsDB->prefix('mylinks_text') . ' t ON t.lid=l.lid WHERE status>0';
    if ($userid != 0) {
      Severity: Minor
      Found in include/search.inc.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status