Sign upLogin

XoopsModules25x/mylinks

View on GitHub
Star
viewcat.php

Summary

Maintainability
B
4 hrs
Test Coverage

File viewcat.php has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
// $Id: viewcat.php 11819 2013-07-09 18:21:40Z zyspec $
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                    Copyright (c) 2000 XOOPS.org                           //
Severity: Minor
Found in viewcat.php - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if ('' == $shotAttribution) {
                            $shotAttribution = $shotObj->getAttribution(true);
                        }
    Severity: Major
    Found in viewcat.php - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          $xoopsTpl->assign(array(
                          'lang_description'  => _MD_MYLINKS_DESCRIPTIONC,
                          'lang_lastupdate'   => _MD_MYLINKS_LASTUPDATEC,
                          'lang_hits'         => _MD_MYLINKS_HITSC,
                          'lang_rating'       => _MD_MYLINKS_RATINGC,
      Severity: Major
      Found in viewcat.php and 1 other location - About 1 hr to fix
      index.php on lines 107..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status