Sign upLogin

XoopsModules25x/news

View on GitHub
Star
blocks/news_top.php

Summary

Maintainability
F
1 wk
Test Coverage

Function b_news_top_show has a Cognitive Complexity of 281 (exceeds 5 allowed). Consider refactoring.
Open

function b_news_top_show($options)
{
    global $xoopsConfig;

    /** @var Helper $helper */
Severity: Minor
Found in blocks/news_top.php - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method b_news_top_show has 475 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function b_news_top_show($options)
{
    global $xoopsConfig;

    /** @var Helper $helper */
Severity: Major
Found in blocks/news_top.php - About 2 days to fix

    File news_top.php has 593 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php declare(strict_types=1);
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
    Severity: Major
    Found in blocks/news_top.php - About 1 day to fix

      Method b_news_top_edit has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function b_news_top_edit($options)
{
    global $xoopsDB;
    $tmpstory = new NewsStory();
    $form     = _MB_NEWS_ORDER . "&nbsp;<select name='options[]'>";
      Severity: Major
      Found in blocks/news_top.php - About 3 hrs to fix

        Function b_news_top_edit has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

        function b_news_top_edit($options)
{
    global $xoopsDB;
    $tmpstory = new NewsStory();
    $form     = _MB_NEWS_ORDER . "&nbsp;<select name='options[]'>";
        Severity: Minor
        Found in blocks/news_top.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    if ((0 == $options[5]) && (1 == $options[4])
                && (($options[6] > 0 && $options[6] == $story->storyid())
                    || (0 == $options[6] && 0 == $key))) {
                $spotlight = [];
                $visible   = true;
        Severity: Major
        Found in blocks/news_top.php - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (0 == $options[5]) { // Use a specific news
                if ($visible) {
                    $spotlightArticle = new NewsStory($options[6]);
                } else {
                    $block['use_spotlight'] = false;
          Severity: Major
          Found in blocks/news_top.php and 1 other location - About 1 hr to fix
          blocks/news_top.php on lines 196..207

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (0 == $options[5]) { // Use a specific news
                $tmpstory = $permstory ?? new NewsStory($options[6]);
            } else { // Use the most recent news
                $stories = [];
                $stories = NewsStory::getAllPublished(1, 0, $restricted, 0, 1, true, $options[0]);
          Severity: Major
          Found in blocks/news_top.php and 1 other location - About 1 hr to fix
          blocks/news_top.php on lines 512..527

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status