Sign upLogin

XoopsModules25x/news

View on GitHub
Star
class/ObjectTree.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method makeSelectElement has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $name,
        $fieldName,
        $prefix = '-',
        $selected = '',
        $addEmptyOption = false,
Severity: Major
Found in class/ObjectTree.php - About 1 hr to fix

    Method makeSelBox has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $name,
        $fieldName,
        $prefix = '-',
        $selected = '',
        $addEmptyOption = false,
    Severity: Major
    Found in class/ObjectTree.php - About 50 mins to fix

      Method makeSelBoxOptions has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function makeSelBoxOptions($fieldName, $selected, $key, &$ret, $prefix_orig, $prefix_curr = ''): void
      Severity: Minor
      Found in class/ObjectTree.php - About 45 mins to fix

        Method addSelectOptions has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function addSelectOptions($element, $fieldName, $key, $prefix_orig, $prefix_curr = ''): void
        Severity: Minor
        Found in class/ObjectTree.php - About 35 mins to fix

          Function makeSelBoxOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function makeSelBoxOptions($fieldName, $selected, $key, &$ret, $prefix_orig, $prefix_curr = ''): void
    {
        if ($key > 0) {
            $value = $this->tree[$key]['obj']->getVar($this->myId);
            $ret   .= '<option value="' . $value . '"';
          Severity: Minor
          Found in class/ObjectTree.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getAllChild has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getAllChild($key, $ret = [])
    {
        if (isset($this->tree[$key]['child'])) {
            foreach ($this->tree[$key]['child'] as $childKey) {
                $ret[$childKey] = $this->tree[$childKey]['obj'];
          Severity: Minor
          Found in class/ObjectTree.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status