XoopsModules25x/news

View on GitHub
class/XoopsTree.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method makeMySelBox has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' == $sel_name) {
            $sel_name = $this->id;
        }
Severity: Minor
Found in class/XoopsTree.php - About 1 hr to fix

    Function makeMySelBox has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
        {
            if ('' == $sel_name) {
                $sel_name = $this->id;
            }
    Severity: Minor
    Found in class/XoopsTree.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method makeMySelBox has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    Severity: Minor
    Found in class/XoopsTree.php - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status