XoopsModules25x/smallworld

View on GitHub
class/Common/Resizer.php

Summary

Maintainability
D
2 days
Test Coverage

Function resizeImage has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function resizeImage()
    {
        // check file extension
        switch ($this->imageMimetype) {
            case'image/png':
Severity: Minor
Found in class/Common/Resizer.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resizeImage has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function resizeImage()
    {
        // check file extension
        switch ($this->imageMimetype) {
            case'image/png':
Severity: Major
Found in class/Common/Resizer.php - About 2 hrs to fix

    Method mergeImage has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function mergeImage()
        {
            $dest = imagecreatefromjpeg($this->endFile);
            $src  = imagecreatefromjpeg($this->sourceFile);
            if (4 == $this->mergeType) {
    Severity: Major
    Found in class/Common/Resizer.php - About 2 hrs to fix

      Method resizeAndCrop has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function resizeAndCrop()
          {
              // check file extension
              switch ($this->imageMimetype) {
                  case 'image/png':
      Severity: Minor
      Found in class/Common/Resizer.php - About 2 hrs to fix

        Function mergeImage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function mergeImage()
            {
                $dest = imagecreatefromjpeg($this->endFile);
                $src  = imagecreatefromjpeg($this->sourceFile);
                if (4 == $this->mergeType) {
        Severity: Minor
        Found in class/Common/Resizer.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function resizeAndCrop has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function resizeAndCrop()
            {
                // check file extension
                switch ($this->imageMimetype) {
                    case 'image/png':
        Severity: Minor
        Found in class/Common/Resizer.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method rotateImage has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function rotateImage()
            {
                // check file extension
                switch ($this->imageMimetype) {
                    case 'image/png':
        Severity: Minor
        Found in class/Common/Resizer.php - About 1 hr to fix

          Function rotateImage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function rotateImage()
              {
                  // check file extension
                  switch ($this->imageMimetype) {
                      case 'image/png':
          Severity: Minor
          Found in class/Common/Resizer.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in class/Common/Resizer.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in class/Common/Resizer.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return false;
              Severity: Major
              Found in class/Common/Resizer.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in class/Common/Resizer.php - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status