Sign upLogin

XoopsModules25x/smallworld

View on GitHub
Star
class/SwDatabase.php

Summary

Maintainability
F
3 days
Test Coverage

File SwDatabase.php has 455 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace XoopsModules\Smallworld;

/*
Severity: Minor
Found in class/SwDatabase.php - About 6 hrs to fix

    Method handlePosts has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handlePosts()
    {
        $GLOBALS['xoopsLogger']->activated = false;
        if ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser'] instanceof \XoopsUser) {
            $uid = $GLOBALS['xoopsUser']->uid();
    Severity: Major
    Found in class/SwDatabase.php - About 3 hrs to fix

      Function smallworld_remDir has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function smallworld_remDir($userid, $directory, $empty = false)
    {
        //@todo verify $userid should be int and then sanitize $userid accordingly before
        //      executing this routine
        if (!empty($userid)) {
      Severity: Minor
      Found in class/SwDatabase.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      SwDatabase has 25 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class SwDatabase
{
    /**
     * getJobsToDiv method
     *
      Severity: Minor
      Found in class/SwDatabase.php - About 2 hrs to fix

        Function handlePosts has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function handlePosts()
    {
        $GLOBALS['xoopsLogger']->activated = false;
        if ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser'] instanceof \XoopsUser) {
            $uid = $GLOBALS['xoopsUser']->uid();
        Severity: Minor
        Found in class/SwDatabase.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method smallworld_remDir has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function smallworld_remDir($userid, $directory, $empty = false)
    {
        //@todo verify $userid should be int and then sanitize $userid accordingly before
        //      executing this routine
        if (!empty($userid)) {
        Severity: Minor
        Found in class/SwDatabase.php - About 1 hr to fix

          Function SmallworldDeleteDirectory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function SmallworldDeleteDirectory($userid)
    {
        $dirname = XOOPS_ROOT_PATH . '/uploads/albums_smallworld' . '/' . (int)$userid . '/';
        if (is_dir($dirname)) {
            $dir_handle = opendir($dirname);
          Severity: Minor
          Found in class/SwDatabase.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method deleteAccount has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function deleteAccount($userid)
    {
        $userid = (int)$userid;
        $user     = new \XoopsUser($userid);
        $username = $user->uname();
          Severity: Minor
          Found in class/SwDatabase.php - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!empty($userid)) {
            if ('/' === mb_substr($directory, -1)) {
                $directory = mb_substr($directory, 0, -1);
            }
            Severity: Major
            Found in class/SwDatabase.php and 1 other location - About 1 day to fix
            class/DoSync.php on lines 99..128

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 249.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status