XoopsModules25x/tag

View on GitHub

Showing 105 of 1,477 total issues

Function render has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function render(?array $block = null)
    {
        \xoops_load('XoopsFormLoader');
        \xoops_loadLanguage('common', $this->moduleDirNameUpper);

Severity: Minor
Found in class/Common/Blocksadmin.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getByLimit has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
    {//&getByLimit($criteria = null, $fromStats = true)
        $ret = [];
        if ($fromStats) {
            $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
Severity: Major
Found in class/TagHandler.php - About 2 hrs to fix

    Function setType has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function setType($value = ''): void
        {
            if ('' !== $value) {
                if (\is_array($value)) {
                    $value       = isset($value['type']) ? \mb_strtolower($value['type']) : 'text';
    Severity: Minor
    Found in class/FormValidatedInput.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method isBlockCloned has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function isBlockCloned(int $bid, string $bside, string $bweight, string $bvisible, string $bcachetime, ?array $bmodule, ?array $options, ?array $groups): void
        {
            \xoops_loadLanguage('admin', 'system');
            \xoops_loadLanguage('admin/blocksadmin', 'system');
            \xoops_loadLanguage('admin/groups', 'system');
    Severity: Major
    Found in class/Common/Blocksadmin.php - About 2 hrs to fix

      Method orderBlock has 15 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              array $bid,
              array $oldtitle,
              array $oldside,
              array $oldweight,
              array $oldvisible,
      Severity: Major
      Found in class/Common/Blocksadmin.php - About 1 hr to fix

        Method getItems has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getItems(\CriteriaElement $criteria = null): array
            {
                $ret = [];
                $sql = '    SELECT o.tl_id, o.tag_itemid, o.tag_modid, o.tag_catid, o.tag_time';
                $sql .= "    FROM {$this->table_link} AS o LEFT JOIN {$this->table} AS l ON l.{$this->keyName} = o.{$this->keyName}";
        Severity: Minor
        Found in class/TagHandler.php - About 1 hr to fix

          Function tag_search has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          function tag_search($queryarray, $andor, $limit, $offset, $userid)
          {
              $ret   = [];
              $count = is_array($queryarray) ? count($queryarray) : 0;
              if (0 >= $count) {
          Severity: Minor
          Found in include/search.inc.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getTagbar has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getTagbar($tags, int $catid = 0, int $modid = 0): array
              {
                  static $loaded, $delimiter;
          
                  if (empty($tags)) {
          Severity: Minor
          Found in class/Tagbar.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method checkVerModule has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function checkVerModule(Helper $helper, ?string $source = 'github', ?string $default = 'master'): ?array
              {
                  $moduleDirName      = \basename(\dirname(__DIR__, 2));
                  $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
                  $update             = '';
          Severity: Minor
          Found in class/Common/VersionChecks.php - About 1 hr to fix

            Method updateBlock has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function updateBlock(int $bid, string $btitle, string $bside, string $bweight, string $bvisible, string $bcachetime, ?array $bmodule, ?array $options, ?array $groups): void
                {
                    $myblock = new \XoopsBlock($bid);
                    $myblock->setVar('title', $btitle);
                    $myblock->setVar('weight', $bweight);
            Severity: Minor
            Found in class/Common/Blocksadmin.php - About 1 hr to fix

              Method tag_block_cloud_show has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function tag_block_cloud_show(array $options, string $dirname = '', int $catid = 0)
              {
                  if (!xoops_isActiveModule('tag')) {
                      return false;
                  }
              Severity: Minor
              Found in blocks/block.php - About 1 hr to fix

                Method tag_search has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function tag_search($queryarray, $andor, $limit, $offset, $userid)
                {
                    $ret   = [];
                    $count = is_array($queryarray) ? count($queryarray) : 0;
                    if (0 >= $count) {
                Severity: Minor
                Found in include/search.inc.php - About 1 hr to fix

                  Function getByLimit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function &getByLimit($limit = Constants::UNLIMITED, $start = Constants::BEGINNING, \CriteriaElement $criteria = null, $fields = null, $fromStats = true): ?array
                      {//&getByLimit($criteria = null, $fromStats = true)
                          $ret = [];
                          if ($fromStats) {
                              $sql = "SELECT DISTINCT(o.{$this->keyName}), o.tag_term, o.tag_status, SUM(l.tag_count) AS count , l.tag_modid" . " FROM {$this->table} AS o LEFT JOIN {$this->table_stats} AS l ON l.{$this->keyName} = o.{$this->keyName}";
                  Severity: Minor
                  Found in class/TagHandler.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getTagbar has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getTagbar($tags, int $catid = 0, int $modid = 0): array
                      {
                          static $loaded, $delimiter;
                  
                          if (empty($tags)) {
                  Severity: Minor
                  Found in class/Tagbar.php - About 1 hr to fix

                    Function isBlockCloned has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function isBlockCloned(int $bid, string $bside, string $bweight, string $bvisible, string $bcachetime, ?array $bmodule, ?array $options, ?array $groups): void
                        {
                            \xoops_loadLanguage('admin', 'system');
                            \xoops_loadLanguage('admin/blocksadmin', 'system');
                            \xoops_loadLanguage('admin/groups', 'system');
                    Severity: Minor
                    Found in class/Common/Blocksadmin.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function tag_block_cloud_show has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function tag_block_cloud_show(array $options, string $dirname = '', int $catid = 0)
                    {
                        if (!xoops_isActiveModule('tag')) {
                            return false;
                        }
                    Severity: Minor
                    Found in blocks/block.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method orderBlock has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function orderBlock(
                            array $bid,
                            array $oldtitle,
                            array $oldside,
                            array $oldweight,
                    Severity: Minor
                    Found in class/Common/Blocksadmin.php - About 1 hr to fix

                      Method cloneBlock has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function cloneBlock(int $bid): void
                          {
                              //require __DIR__ . '/admin_header.php';
                              //        \xoops_cp_header();
                      
                      
                      Severity: Minor
                      Found in class/Common/Blocksadmin.php - About 1 hr to fix

                        Method editBlock has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function editBlock(int $bid): void
                            {
                                //        require_once \dirname(__DIR__,2) . '/admin/admin_header.php';
                                //        \xoops_cp_header();
                                \xoops_loadLanguage('admin', 'system');
                        Severity: Minor
                        Found in class/Common/Blocksadmin.php - About 1 hr to fix

                          Function rrmdir has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function rrmdir(string $src): bool
                              {
                                  // Only continue if user is a 'global' Admin
                                  if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
                                      return false;
                          Severity: Minor
                          Found in class/Common/FilesManagement.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language