XoopsModules25x/userlog

View on GitHub
blocks/views.php

Summary

Maintainability
C
1 day
Test Coverage

Method userlog_views_edit has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function userlog_views_edit($options)
{
    // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
    xoops_load('XoopsFormLoader');
    // $form = new XoopsBlockForm(); //reserve for 2.6
Severity: Major
Found in blocks/views.php - About 2 hrs to fix

    Function userlog_views_edit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function userlog_views_show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '136', column '26').
    Open

        $groupRadioEle = new XoopsFormRadio(_AM_USERLOG_GROUPS, "options[{$i}]", !empty($options[$i]));
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '124', column '20').
    Open

        $timeEle = new XoopsFormText(_AM_USERLOG_LOG_TIMEGT, "options[{$i}]", 10, 255, $options[$i]);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '86', column '26').
    Open

        $criteria      = new CriteriaCompo();
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '88', column '24').
    Open

        $criteria->add(new Criteria('isactive', 1));
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '87', column '24').
    Open

        $criteria->add(new Criteria('hasnotification', 1));
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '140', column '27').
    Open

        $groupSelectEle = new XoopsFormSelectGroup(_AM_USERLOG_GROUPS, "options[{$i}]", true, explode(',', $options[$i]), 3, true);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '82', column '17').
    Open

        $form = new XoopsThemeForm(_AM_USERLOG_VIEW, 'views', '');
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '133', column '26').
    Open

        $userEle       = new XoopsFormLabel(_AM_USERLOG_UID, $userRadioEle->render() . $userSelectEle->render());
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '103', column '24').
    Open

        $numitemsEle = new XoopsFormText(_AM_USERLOG_ITEMS_NUM, "options[{$i}]", 10, 255, (int)$options[$i]);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '114', column '26').
    Open

            $viewsEle  = new XoopsFormLabel(_AM_USERLOG_ITEMS, $check_all . "<br\>" . $viewsEle->render());
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '132', column '26').
    Open

        $userSelectEle = new XoopsFormSelectUser(_AM_USERLOG_UID, "options[{$i}]", true, explode(',', $options[$i]), 3, true);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '141', column '27').
    Open

        $groupEle       = new XoopsFormLabel(_AM_USERLOG_GROUPS, $groupRadioEle->render() . $groupSelectEle->render());
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '154', column '21').
    Open

        $orderEle = new XoopsFormSelect(_AM_USERLOG_ORDER, "options[{$i}]", $options[$i]);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '108', column '30').
    Open

        $viewsEle          = new XoopsFormCheckBox(_AM_USERLOG_ITEMS, "options[{$i}][]", !empty($options_views) ? $options_views : 0);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '128', column '25').
    Open

        $userRadioEle = new XoopsFormRadio(_AM_USERLOG_UID, "options[{$i}]", $options[$i]);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '144', column '20').
    Open

        $sortEle = new XoopsFormSelect(_AM_USERLOG_SORT, "options[{$i}]", $options[$i]);
    Severity: Minor
    Found in blocks/views.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'UserlogLog' in method 'userlog_views_show'.
    Open

        $loglogObj = UserlogLog::getInstance();
    Severity: Minor
    Found in blocks/views.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method userlog_views_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

        } else {
            // prevent to select
            $viewsEle->addOption(0, _NONE);
            $viewsEle->setExtra('class="hidden"');
        }
    Severity: Minor
    Found in blocks/views.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused local variables such as '$key'.
    Open

            foreach ($options_views as $key => $item) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            foreach ($options_views as $key => $item) {
                $module_script_item = explode('-', $item); // news:article.php-storyid news:index.php-storytopic => $module["news"]=array("storyid","storytopic");
                $module_script      = explode(':', $module_script_item[0]); //  news:article.php => $module_script = array(news,article.php);
                if (!isset($module[$module_script[0]])) {
                    $module[$module_script[0]]['item_name'] = [];
    Severity: Major
    Found in blocks/views.php and 1 other location - About 5 hrs to fix
    admin/stats.php on lines 158..167

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            foreach ($not_config['category'] as $category) {
                if (!empty($category['item_name'])) {
                    $script                                                                      = is_array($category['subscribe_from']) ? implode(':', $category['subscribe_from']) : $category['subscribe_from'];
                    $hasviews[$module->dirname() . ':' . $script . '-' . $category['item_name']] = $module->dirname() . '/' . $script . '?' . $category['item_name'] . '=ITEM_ID';
                }
    Severity: Major
    Found in blocks/views.php and 1 other location - About 2 hrs to fix
    admin/stats.php on lines 204..209

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

        $i = 0;
    Severity: Minor
    Found in blocks/views.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 28 and the first side effect is on line 22.
    Open

    <?php
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 130 characters
    Open

        $viewsEle          = new XoopsFormCheckBox(_AM_USERLOG_ITEMS, "options[{$i}][]", !empty($options_views) ? $options_views : 0);
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

        $groupSelectEle = new XoopsFormSelectGroup(_AM_USERLOG_GROUPS, "options[{$i}]", true, explode(',', $options[$i]), 3, true);
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 207 characters
    Open

                    $script                                                                      = is_array($category['subscribe_from']) ? implode(':', $category['subscribe_from']) : $category['subscribe_from'];
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 158 characters
    Open

                $module_script_item = explode('-', $item); // news:article.php-storyid news:index.php-storytopic => $module["news"]=array("storyid","storytopic");
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 137 characters
    Open

                $module_script      = explode(':', $module_script_item[0]); //  news:article.php => $module_script = array(news,article.php);
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 137 characters
    Open

        $userRadioEle->addOption(($options[$i] != -1) ? $options[$i] : 0, _SELECT); // if no user in selection box it select uid=0 anon users
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

        $userSelectEle = new XoopsFormSelectUser(_AM_USERLOG_UID, "options[{$i}]", true, explode(',', $options[$i]), 3, true);
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 130 characters
    Open

            $options_views = explode(',', $options[1]); // item views in where claus eg: news-storyid, newbb-topic_id, news-storytopic
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 174 characters
    Open

                    $hasviews[$module->dirname() . ':' . $script . '-' . $category['item_name']] = $module->dirname() . '/' . $script . '?' . $category['item_name'] . '=ITEM_ID';
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

            $viewsEle->setExtra("onchange = \"validate('options[{$i}][]','checkbox', true)\""); // prevent user select no option
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 152 characters
    Open

                $module[$module_script[0]]['script']      = array_unique(array_merge($module[$module_script[0]]['script'], array_slice($module_script, 1)));
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

        $items          = $loglogObj->getViews($options[0], 0, $options[5], $options[6], $module, $options[2], $users, $groups);
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    Line exceeds 120 characters; contains 145 characters
    Open

        $groupRadioEle->addOption(!empty($options[$i]) ? $options[$i] : 2, _SELECT); // if no group in selection box it select gid=2 registered users
    Severity: Minor
    Found in blocks/views.php by phpcodesniffer

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $options_views is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $options_views is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $options_views is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $options_views is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script_item is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $not_config is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $options_views is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script_item is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $check_all is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script_item is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $check_all is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $module_script is not named in camelCase.
    Open

    function userlog_views_show($options)
    {
        $loglogObj = UserlogLog::getInstance();
        $module    = [];
        if (!empty($options[1])) {
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $not_config is not named in camelCase.
    Open

    function userlog_views_edit($options)
    {
        // require_once XOOPS_ROOT_PATH . "/class/blockform.php"; //reserve for 2.6
        xoops_load('XoopsFormLoader');
        // $form = new XoopsBlockForm(); //reserve for 2.6
    Severity: Minor
    Found in blocks/views.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status