XoopsModules25x/wfdownloads

View on GitHub
admin/downloads.php

Summary

Maintainability
F
5 days
Test Coverage

File downloads.php has 811 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.
Severity: Major
Found in admin/downloads.php - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if ($fid) {
                        require_once XOOPS_ROOT_PATH . '/modules/formulize/include/formdisplay.php';
                        require_once XOOPS_ROOT_PATH . '/modules/formulize/include/functions.php';
                        $customArray['fid']           = $fid;
                        $customArray['formulize_mgr'] = $helper->getHandler('Elements', 'formulize');
    Severity: Major
    Found in admin/downloads.php and 1 other location - About 1 day to fix
    submit.php on lines 147..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 293.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (!$thisIsANewRecord && ($downloadObj->getVar('version') != $version)) {
                // Trigger the three events related to modified files (one for the file, category, and global event categories respectively)
                $tags                  = [];
                $tags['FILE_NAME']     = $title;
                $tags['FILE_URL']      = WFDOWNLOADS_URL . "/singlefile.php?cid={$cid}&amp;lid={$lid}";
    Severity: Major
    Found in admin/downloads.php and 1 other location - About 6 hrs to fix
    submit.php on lines 381..397

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 220.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                if ($publishedDownloadCount > 0) {
                    foreach ($publishedDownloadObjs as $publishedDownloadObj) {
                        $publishedDownload_array                        = $publishedDownloadObj->toArray();
                        $publishedDownload_array['title_html']          = htmlspecialchars(trim($publishedDownload_array['title']), ENT_QUOTES | ENT_HTML5);
                        $publishedDownload_array['category_title']      = $categoryObjs[$publishedDownload_array['cid']]['title'];
    Severity: Major
    Found in admin/downloads.php and 3 other locations - About 3 hrs to fix
    admin/downloads.php on lines 767..776
    admin/downloads.php on lines 791..800
    admin/downloads.php on lines 813..822

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                if ($offlineDownloadCount > 0) {
                    foreach ($offlineDownloadObjs as $offlineDownloadObj) {
                        $offlineDownload_array                        = $offlineDownloadObj->toArray();
                        $offlineDownload_array['title_html']          = htmlspecialchars(trim($offlineDownload_array['title']), ENT_QUOTES | ENT_HTML5);
                        $offlineDownload_array['category_title']      = $categories[$offlineDownload_array['cid']]['title'];
    Severity: Major
    Found in admin/downloads.php and 3 other locations - About 3 hrs to fix
    admin/downloads.php on lines 694..703
    admin/downloads.php on lines 767..776
    admin/downloads.php on lines 791..800

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                if ($autopublishedDownloadCount > 0) {
                    foreach ($autopublishedDownloadObjs as $autopublishedDownloadObj) {
                        $autopublishedDownload_array                        = $autopublishedDownloadObj->toArray();
                        $autopublishedDownload_array['title_html']          = htmlspecialchars(trim($autopublishedDownload_array['title']), ENT_QUOTES | ENT_HTML5);
                        $autopublishedDownload_array['category_title']      = $categories[$autopublishedDownload_array['cid']]['title'];
    Severity: Major
    Found in admin/downloads.php and 3 other locations - About 3 hrs to fix
    admin/downloads.php on lines 694..703
    admin/downloads.php on lines 791..800
    admin/downloads.php on lines 813..822

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                if ($expiredDownloadCount > 0) {
                    foreach ($expiredDownloadObjs as $expiredDownloadObj) {
                        $expiredDownload_array                        = $expiredDownloadObj->toArray();
                        $expiredDownload_array['title_html']          = htmlspecialchars(trim($expiredDownload_array['title']), ENT_QUOTES | ENT_HTML5);
                        $expiredDownload_array['category_title']      = $categories[$expiredDownload_array['cid']]['title'];
    Severity: Major
    Found in admin/downloads.php and 3 other locations - About 3 hrs to fix
    admin/downloads.php on lines 694..703
    admin/downloads.php on lines 767..776
    admin/downloads.php on lines 813..822

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status