XoopsModules25x/wfdownloads

View on GitHub
class/MulticolumnsThemeForm.php

Summary

Maintainability
C
1 day
Test Coverage

Function render has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function render()
    {
        $ele_name = $this->getName();
        $ret      = '';
        $ret      .= "<form name='{$ele_name}' id='{$ele_name}' action='{$this->getAction()}' method='{$this->getMethod()}' onsubmit='return xoopsFormValidate_{$ele_name}();' {$this->getExtra()} >" . NWLINE;
Severity: Minor
Found in class/MulticolumnsThemeForm.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addElement has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function addElement($formElement, $required = false, $row = null, $column = null)
    {
        if (null === $row) {
            $row = $this->_rows;
        }
Severity: Minor
Found in class/MulticolumnsThemeForm.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function render()
    {
        $ele_name = $this->getName();
        $ret      = '';
        $ret      .= "<form name='{$ele_name}' id='{$ele_name}' action='{$this->getAction()}' method='{$this->getMethod()}' onsubmit='return xoopsFormValidate_{$ele_name}();' {$this->getExtra()} >" . NWLINE;
Severity: Major
Found in class/MulticolumnsThemeForm.php - About 2 hrs to fix

    Method addElement has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function addElement($formElement, $required = false, $row = null, $column = null)
        {
            if (null === $row) {
                $row = $this->_rows;
            }
    Severity: Minor
    Found in class/MulticolumnsThemeForm.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status