XoopsModules25x/wfdownloads

View on GitHub
include/search.inc.php

Summary

Maintainability
D
2 days
Test Coverage

Function wfdownloads_search has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

function wfdownloads_search($queryArray, $andor, $limit, $offset, $userId = 0, $categories = [], $sortBy = 0, $searchIn = '', $extra = '')
{
    $helper = Helper::getInstance();

    $userGroups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [0 => XOOPS_GROUP_ANONYMOUS];
Severity: Minor
Found in include/search.inc.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wfdownloads_search has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function wfdownloads_search($queryArray, $andor, $limit, $offset, $userId = 0, $categories = [], $sortBy = 0, $searchIn = '', $extra = '')
{
    $helper = Helper::getInstance();

    $userGroups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [0 => XOOPS_GROUP_ANONYMOUS];
Severity: Major
Found in include/search.inc.php - About 5 hrs to fix

    Method wfdownloads_search has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function wfdownloads_search($queryArray, $andor, $limit, $offset, $userId = 0, $categories = [], $sortBy = 0, $searchIn = '', $extra = '')
    Severity: Major
    Found in include/search.inc.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status